Module Name: src
Committed By: dyoung
Date: Tue Apr 7 18:01:20 UTC 2009
Modified Files:
src/sys/dev/ata: ata.c
Log Message:
Cosmetic: flag a potential problem in ata_channel_attach():
it initializes a callout that does not appear to be destroyed
anywhere. Every callout_init() should ordinarily be matched by a
callout_destroy().
To generate a diff of this commit:
cvs rdiff -u -r1.104 -r1.105 src/sys/dev/ata/ata.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/ata/ata.c
diff -u src/sys/dev/ata/ata.c:1.104 src/sys/dev/ata/ata.c:1.105
--- src/sys/dev/ata/ata.c:1.104 Fri Apr 3 21:31:08 2009
+++ src/sys/dev/ata/ata.c Tue Apr 7 18:01:20 2009
@@ -1,4 +1,4 @@
-/* $NetBSD: ata.c,v 1.104 2009/04/03 21:31:08 dyoung Exp $ */
+/* $NetBSD: ata.c,v 1.105 2009/04/07 18:01:20 dyoung Exp $ */
/*
* Copyright (c) 1998, 2001 Manuel Bouyer. All rights reserved.
@@ -30,7 +30,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ata.c,v 1.104 2009/04/03 21:31:08 dyoung Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ata.c,v 1.105 2009/04/07 18:01:20 dyoung Exp $");
#include "opt_ata.h"
@@ -162,6 +162,7 @@
if (chp->ch_flags & ATACH_DISABLED)
return;
+ /* XXX callout_destroy */
callout_init(&chp->ch_callout, 0);
TAILQ_INIT(&chp->ch_queue->queue_xfer);
