Module Name: src
Committed By: drochner
Date: Mon Aug 3 19:41:32 UTC 2009
Modified Files:
src/lib/libm/complex: cacosh.c cacoshf.c
Log Message:
As noticed by Stathis Kamperis, the original implementation does not
always return the correct principal value (with real>=0).
(eg cacosh(ccos(1.0I)) was -1)
Replace by a more ground-up one which should do better.
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/lib/libm/complex/cacosh.c \
src/lib/libm/complex/cacoshf.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/lib/libm/complex/cacosh.c
diff -u src/lib/libm/complex/cacosh.c:1.1 src/lib/libm/complex/cacosh.c:1.2
--- src/lib/libm/complex/cacosh.c:1.1 Mon Aug 20 16:01:30 2007
+++ src/lib/libm/complex/cacosh.c Mon Aug 3 19:41:32 2009
@@ -1,4 +1,4 @@
-/* $NetBSD: cacosh.c,v 1.1 2007/08/20 16:01:30 drochner Exp $ */
+/* $NetBSD: cacosh.c,v 1.2 2009/08/03 19:41:32 drochner Exp $ */
/*-
* Copyright (c) 2007 The NetBSD Foundation, Inc.
@@ -36,6 +36,10 @@
{
double complex w;
+#if 0 /* does not give the principal value */
w = I * cacos(z);
+#else
+ w = clog(z + csqrt(z + 1) * csqrt(z - 1));
+#endif
return w;
}
Index: src/lib/libm/complex/cacoshf.c
diff -u src/lib/libm/complex/cacoshf.c:1.1 src/lib/libm/complex/cacoshf.c:1.2
--- src/lib/libm/complex/cacoshf.c:1.1 Mon Aug 20 16:01:31 2007
+++ src/lib/libm/complex/cacoshf.c Mon Aug 3 19:41:32 2009
@@ -1,4 +1,4 @@
-/* $NetBSD: cacoshf.c,v 1.1 2007/08/20 16:01:31 drochner Exp $ */
+/* $NetBSD: cacoshf.c,v 1.2 2009/08/03 19:41:32 drochner Exp $ */
/*-
* Copyright (c) 2007 The NetBSD Foundation, Inc.
@@ -36,6 +36,10 @@
{
float complex w;
+#if 0 /* does not give the principal value */
w = I * cacosf(z);
+#else
+ w = clogf(z + csqrtf(z + 1) * csqrtf(z - 1));
+#endif
return w;
}
