CVS commit: src/bin/ksh

[David Laight]

Module Name:    src
Committed By:   dsl
Date:           Sat Oct 31 21:54:01 UTC 2009

Modified Files:
        src/bin/ksh: history.c

Log Message:
Avoid generating a corrupt history file if multiple ksh exit together.
Fixes PR/28912


To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/bin/ksh/history.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


Modified files:

Index: src/bin/ksh/history.c
diff -u src/bin/ksh/history.c:1.9 src/bin/ksh/history.c:1.10
--- src/bin/ksh/history.c:1.9	Sun Jun 26 19:09:00 2005
+++ src/bin/ksh/history.c	Sat Oct 31 21:54:01 2009
@@ -1,4 +1,4 @@
-/*	$NetBSD: history.c,v 1.9 2005/06/26 19:09:00 christos Exp $	*/
+/*	$NetBSD: history.c,v 1.10 2009/10/31 21:54:01 dsl Exp $	*/
 
 /*
  * command history
@@ -19,7 +19,7 @@
 #include <sys/cdefs.h>
 
 #ifndef lint
-__RCSID("$NetBSD: history.c,v 1.9 2005/06/26 19:09:00 christos Exp $");
+__RCSID("$NetBSD: history.c,v 1.10 2009/10/31 21:54:01 dsl Exp $");
 #endif
 
 
@@ -740,20 +740,27 @@
 hist_finish()
 {
   static int once;
+  int fd;
   FILE *fh;
   register int i;
   register char **hp;
 
   if (once++)
     return;
+  if (hname == NULL || hname[0] == 0)
+    return;
+
   /* check how many we have */
   i = histptr - histlist;
   if (i >= histsize)
     hp = &histptr[-histsize];
   else
     hp = histlist;
-  if (hname && (fh = fopen(hname, "w")))
-  {
+
+  fd = open(hname, O_WRONLY | O_CREAT | O_TRUNC | O_EXLOCK, 0777);
+  /* Remove anything written before we got the lock */
+  ftruncate(fd, 0);
+  if (fd >= 0 && (fh = fdopen(fd, "w"))) {
     for (i = 0; hp + i <= histptr && hp[i]; i++)
       fprintf(fh, "%s%c", hp[i], '\0');
     fclose(fh);