CVS commit: src/sys/external/bsd/drm2/dist/drm/nouveau/nvkm/subdev/mxm

[Taylor R Campbell]

Module Name:    src
Committed By:   riastradh
Date:           Mon Aug 27 07:41:00 UTC 2018

Modified Files:
        src/sys/external/bsd/drm2/dist/drm/nouveau/nvkm/subdev/mxm:
            nouveau_nvkm_subdev_mxm_mxms.c

Log Message:
Say no to sprintf!


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 \
    
src/sys/external/bsd/drm2/dist/drm/nouveau/nvkm/subdev/mxm/nouveau_nvkm_subdev_mxm_mxms.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


Modified files:

Index: src/sys/external/bsd/drm2/dist/drm/nouveau/nvkm/subdev/mxm/nouveau_nvkm_subdev_mxm_mxms.c
diff -u src/sys/external/bsd/drm2/dist/drm/nouveau/nvkm/subdev/mxm/nouveau_nvkm_subdev_mxm_mxms.c:1.2 src/sys/external/bsd/drm2/dist/drm/nouveau/nvkm/subdev/mxm/nouveau_nvkm_subdev_mxm_mxms.c:1.3
--- src/sys/external/bsd/drm2/dist/drm/nouveau/nvkm/subdev/mxm/nouveau_nvkm_subdev_mxm_mxms.c:1.2	Mon Aug 27 04:58:34 2018
+++ src/sys/external/bsd/drm2/dist/drm/nouveau/nvkm/subdev/mxm/nouveau_nvkm_subdev_mxm_mxms.c	Mon Aug 27 07:41:00 2018
@@ -1,4 +1,4 @@
-/*	$NetBSD: nouveau_nvkm_subdev_mxm_mxms.c,v 1.2 2018/08/27 04:58:34 riastradh Exp $	*/
+/*	$NetBSD: nouveau_nvkm_subdev_mxm_mxms.c,v 1.3 2018/08/27 07:41:00 riastradh Exp $	*/
 
 /*
  * Copyright 2012 Red Hat Inc.
@@ -24,7 +24,7 @@
  * Authors: Ben Skeggs
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: nouveau_nvkm_subdev_mxm_mxms.c,v 1.2 2018/08/27 04:58:34 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nouveau_nvkm_subdev_mxm_mxms.c,v 1.3 2018/08/27 07:41:00 riastradh Exp $");
 
 #include "mxms.h"
 
@@ -160,13 +160,15 @@ mxms_foreach(struct nvkm_mxm *mxm, u8 ty
 			int i, j;
 
 			for (j = headerlen - 1, ptr = data; j >= 0; j--)
-				ptr += sprintf(ptr, "%02x", dump[j]);
+				ptr += snprintf(ptr, sizeof data - (ptr - data),
+				    "%02x", dump[j]);
 			dump += headerlen;
 
 			nvkm_debug(subdev, "%4s: %s\n", mxms_desc[type], data);
 			for (i = 0; i < entries; i++, dump += recordlen) {
 				for (j = recordlen - 1, ptr = data; j >= 0; j--)
-					ptr += sprintf(ptr, "%02x", dump[j]);
+					ptr += snprintf(ptr, sizeof data -
+					    (ptr - data), "%02x", dump[j]);
 				nvkm_debug(subdev, "      %s\n", data);
 			}
 		}