Module Name: src
Committed By: martin
Date: Sun Sep 23 17:16:33 UTC 2018
Modified Files:
src/usr.bin/printf [netbsd-8]: printf.c
Log Message:
Pull up following revision(s) (requested by kre in ticket #1020):
usr.bin/printf/printf.c: revision 1.46
A truly ancient bug found by Edgar Fuss
When printf is running builtin in a sh, global vars aren't reset to
0 between invocations. This affects "rval" which remembers state
from a previous %b \c and thereafter always exits after the first
format conversion, until we get a conversion that generates an
error (which resets the flag almost by accident)
printf %b abc\\c
abc (no \n)
printf %s%s hello world
hello (no \n, of course, no world ...)
printf %s%s hello world
hello
printf %s%s hello world
hello
printf %d hello
printf: hello: expected numeric value
0 (no \n)
printf %s%s hello world
helloworld (no \n, and we are back!)
This affects both /bin/sh and /bin/csh (and has for a very long time).
XXX pullup -8
To generate a diff of this commit:
cvs rdiff -u -r1.37.8.2 -r1.37.8.3 src/usr.bin/printf/printf.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/printf/printf.c
diff -u src/usr.bin/printf/printf.c:1.37.8.2 src/usr.bin/printf/printf.c:1.37.8.3
--- src/usr.bin/printf/printf.c:1.37.8.2 Sat Sep 1 06:28:23 2018
+++ src/usr.bin/printf/printf.c Sun Sep 23 17:16:33 2018
@@ -1,4 +1,4 @@
-/* $NetBSD: printf.c,v 1.37.8.2 2018/09/01 06:28:23 martin Exp $ */
+/* $NetBSD: printf.c,v 1.37.8.3 2018/09/23 17:16:33 martin Exp $ */
/*
* Copyright (c) 1989, 1993
@@ -41,7 +41,7 @@ __COPYRIGHT("@(#) Copyright (c) 1989, 19
#if 0
static char sccsid[] = "@(#)printf.c 8.2 (Berkeley) 3/22/95";
#else
-__RCSID("$NetBSD: printf.c,v 1.37.8.2 2018/09/01 06:28:23 martin Exp $");
+__RCSID("$NetBSD: printf.c,v 1.37.8.3 2018/09/23 17:16:33 martin Exp $");
#endif
#endif /* not lint */
@@ -134,6 +134,8 @@ int main(int argc, char *argv[])
(void)setlocale (LC_ALL, "");
#endif
+ rval = 0; /* clear for builtin versions (avoid holdover) */
+
while ((o = getopt(argc, argv, "")) != -1) {
switch (o) {
case '?':
