Module Name:    src
Committed By:   maxv
Date:           Thu Nov 15 14:19:23 UTC 2018

Modified Files:
        src/sys/uvm: uvm_swap.c

Log Message:
Woah man, fix enormous leak.

        Possible info leak: [len=1056, leaked=931]
        #0 0xffffffff80bad351 in kleak_copyout
        #1 0xffffffff80b2cf64 in uvm_swap_stats.part.1
        #2 0xffffffff80b2d38d in uvm_swap_stats
        #3 0xffffffff80b2d43c in sys_swapctl
        #4 0xffffffff80259b82 in syscall


To generate a diff of this commit:
cvs rdiff -u -r1.177 -r1.178 src/sys/uvm/uvm_swap.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/uvm/uvm_swap.c
diff -u src/sys/uvm/uvm_swap.c:1.177 src/sys/uvm/uvm_swap.c:1.178
--- src/sys/uvm/uvm_swap.c:1.177	Thu Mar 15 03:21:58 2018
+++ src/sys/uvm/uvm_swap.c	Thu Nov 15 14:19:23 2018
@@ -1,4 +1,4 @@
-/*	$NetBSD: uvm_swap.c,v 1.177 2018/03/15 03:21:58 christos Exp $	*/
+/*	$NetBSD: uvm_swap.c,v 1.178 2018/11/15 14:19:23 maxv Exp $	*/
 
 /*
  * Copyright (c) 1995, 1996, 1997, 2009 Matthew R. Green
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uvm_swap.c,v 1.177 2018/03/15 03:21:58 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uvm_swap.c,v 1.178 2018/11/15 14:19:23 maxv Exp $");
 
 #include "opt_uvmhist.h"
 #include "opt_compat_netbsd.h"
@@ -744,6 +744,7 @@ uvm_swap_stats(char *ptr, int misc, 
 			inuse = btodb((uint64_t)sdp->swd_npginuse <<
 			    PAGE_SHIFT);
 
+			memset(&sep, 0, sizeof(sep));
 			swapent_cvt(&sep, sdp, inuse);
 			if (f)
 				(*f)(&sep, &sep);

Reply via email to