Module Name: src Committed By: maxv Date: Thu Nov 29 12:37:22 UTC 2018
Modified Files: src/sys/kern: kern_exit.c Log Message: Fix info leak. There is one branch where 'status' is not initialized at all. + Possible info leak: [len=4, leaked=4] | #0 0xffffffff80baf397 in kleak_copyout | #1 0xffffffff80b56d0c in sys_wait6 | #2 0xffffffff80259c42 in syscall To generate a diff of this commit: cvs rdiff -u -r1.272 -r1.273 src/sys/kern/kern_exit.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/sys/kern/kern_exit.c diff -u src/sys/kern/kern_exit.c:1.272 src/sys/kern/kern_exit.c:1.273 --- src/sys/kern/kern_exit.c:1.272 Thu Jul 12 10:46:48 2018 +++ src/sys/kern/kern_exit.c Thu Nov 29 12:37:22 2018 @@ -1,4 +1,4 @@ -/* $NetBSD: kern_exit.c,v 1.272 2018/07/12 10:46:48 maxv Exp $ */ +/* $NetBSD: kern_exit.c,v 1.273 2018/11/29 12:37:22 maxv Exp $ */ /*- * Copyright (c) 1998, 1999, 2006, 2007, 2008 The NetBSD Foundation, Inc. @@ -67,7 +67,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: kern_exit.c,v 1.272 2018/07/12 10:46:48 maxv Exp $"); +__KERNEL_RCSID(0, "$NetBSD: kern_exit.c,v 1.273 2018/11/29 12:37:22 maxv Exp $"); #include "opt_ktrace.h" #include "opt_dtrace.h" @@ -647,6 +647,7 @@ do_sys_waitid(idtype_t idtype, id_t id, if (child == NULL) { mutex_exit(proc_lock); *pid = 0; + *status = 0; return error; } *pid = child->p_pid;