Module Name: src Committed By: martin Date: Fri Jan 11 15:55:02 UTC 2019
Modified Files: src/sys/net [netbsd-8]: if_ppp.c Log Message: Pull up following revision(s) (requested by knakahara in ticket #1162): sys/net/if_ppp.c: revision 1.162 sys/net/if_ppp.c: revision 1.163 Fix missing mutex_exit in ppp_create(). Fix missing splx in ppp_inproc(). To generate a diff of this commit: cvs rdiff -u -r1.158.8.1 -r1.158.8.2 src/sys/net/if_ppp.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/sys/net/if_ppp.c diff -u src/sys/net/if_ppp.c:1.158.8.1 src/sys/net/if_ppp.c:1.158.8.2 --- src/sys/net/if_ppp.c:1.158.8.1 Thu Jul 26 23:55:31 2018 +++ src/sys/net/if_ppp.c Fri Jan 11 15:55:01 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: if_ppp.c,v 1.158.8.1 2018/07/26 23:55:31 snj Exp $ */ +/* $NetBSD: if_ppp.c,v 1.158.8.2 2019/01/11 15:55:01 martin Exp $ */ /* Id: if_ppp.c,v 1.6 1997/03/04 03:33:00 paulus Exp */ /* @@ -102,7 +102,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: if_ppp.c,v 1.158.8.1 2018/07/26 23:55:31 snj Exp $"); +__KERNEL_RCSID(0, "$NetBSD: if_ppp.c,v 1.158.8.2 2019/01/11 15:55:01 martin Exp $"); #ifdef _KERNEL_OPT #include "ppp.h" @@ -301,6 +301,7 @@ ppp_create(const char *name, int unit) break; else if (unit == sci->sc_unit) { free(sc, M_DEVBUF); + mutex_exit(&ppp_list_lock); return NULL; } } @@ -1722,6 +1723,7 @@ ppp_inproc(struct ppp_softc *sc, struct /* pktq: inet or inet6 cases */ if (__predict_true(pktq)) { if (__predict_false(!pktq_enqueue(pktq, m, 0))) { + splx(s); ifp->if_iqdrops++; goto bad; } @@ -1733,6 +1735,7 @@ ppp_inproc(struct ppp_softc *sc, struct /* ifq: other protocol cases */ if (!inq) { + splx(s); goto bad; } if (IF_QFULL(inq)) {