Module Name: src
Committed By: kamil
Date: Tue Jan 22 03:44:45 UTC 2019
Modified Files:
src/sys/kern: core_elf32.c
Log Message:
Fix code generation for programs with a faulty process map
In case of any errors of scanning the segments reset
their content to a default value with zeros. This is
achieved with shortening the p_filesz parameter.
This allows to emit core(5) files for a process
regardless of its state of mappings, such as mapping
pages after EOF in a file.
Fixes PR lib/53343
To generate a diff of this commit:
cvs rdiff -u -r1.57 -r1.58 src/sys/kern/core_elf32.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/kern/core_elf32.c
diff -u src/sys/kern/core_elf32.c:1.57 src/sys/kern/core_elf32.c:1.58
--- src/sys/kern/core_elf32.c:1.57 Mon Sep 3 16:29:35 2018
+++ src/sys/kern/core_elf32.c Tue Jan 22 03:44:44 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: core_elf32.c,v 1.57 2018/09/03 16:29:35 riastradh Exp $ */
+/* $NetBSD: core_elf32.c,v 1.58 2019/01/22 03:44:44 kamil Exp $ */
/*
* Copyright (c) 2001 Wasabi Systems, Inc.
@@ -40,7 +40,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(1, "$NetBSD: core_elf32.c,v 1.57 2018/09/03 16:29:35 riastradh Exp $");
+__KERNEL_RCSID(1, "$NetBSD: core_elf32.c,v 1.58 2019/01/22 03:44:44 kamil Exp $");
#ifdef _KERNEL_OPT
#include "opt_coredump.h"
@@ -313,8 +313,19 @@ ELFNAMEEND(coredump_getseghdrs)(struct u
int i;
end -= slen;
- if ((error = copyin_proc(ws->p, (void *)end, buf, slen)) != 0)
- return error;
+ if ((error = copyin_proc(ws->p, (void *)end, buf, slen)) != 0) {
+ /*
+ * In case of any errors of scanning the segments reset
+ * their content to a default value with zeros. This is
+ * achieved with shortening the p_filesz parameter.
+ *
+ * This allows to emit core(5) files for a process
+ * regardless of its state of mappings, such as mapping
+ * pages after EOF in a file.
+ */
+ realsize -= slen;
+ continue;
+ }
ep = (const long *) &buf[slen / sizeof(buf[0])];
for (i = 0, ep--; buf <= ep; ep--, i++) {
