Module Name:    src
Committed By:   kamil
Date:           Tue Apr 30 22:32:01 UTC 2019

Modified Files:
        src/sys/kern: sys_ptrace_common.c

Log Message:
Reject ptrace(2) PIOD_READ/WRITE operations with length 0

Return EINVAL for such invalid requests.


To generate a diff of this commit:
cvs rdiff -u -r1.49 -r1.50 src/sys/kern/sys_ptrace_common.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/kern/sys_ptrace_common.c
diff -u src/sys/kern/sys_ptrace_common.c:1.49 src/sys/kern/sys_ptrace_common.c:1.50
--- src/sys/kern/sys_ptrace_common.c:1.49	Tue Apr 30 20:50:30 2019
+++ src/sys/kern/sys_ptrace_common.c	Tue Apr 30 22:32:01 2019
@@ -1,4 +1,4 @@
-/*	$NetBSD: sys_ptrace_common.c,v 1.49 2019/04/30 20:50:30 kamil Exp $	*/
+/*	$NetBSD: sys_ptrace_common.c,v 1.50 2019/04/30 22:32:01 kamil Exp $	*/
 
 /*-
  * Copyright (c) 2008, 2009 The NetBSD Foundation, Inc.
@@ -118,7 +118,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: sys_ptrace_common.c,v 1.49 2019/04/30 20:50:30 kamil Exp $");
+__KERNEL_RCSID(0, "$NetBSD: sys_ptrace_common.c,v 1.50 2019/04/30 22:32:01 kamil Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_ptrace.h"
@@ -1117,6 +1117,10 @@ do_ptrace(struct ptrace_methods *ptm, st
 	case PT_IO:
 		if ((error = ptm->ptm_copyin_piod(&piod, addr, data)) != 0)
 			break;
+		if (piod.piod_len < 1) {
+			error = EINVAL;
+			break;
+		}
 		if ((error = ptrace_doio(l, t, lt, &piod, addr, false)) != 0)
 			break;
 		if (piod.piod_len < 1) {

Reply via email to