Module Name: src
Committed By: wiz
Date: Sun Jan 17 23:10:20 UTC 2010
Modified Files:
src/lib/libc/hash: hashhl.c
Log Message:
Close file handle in error case. Found by cppcheck.
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/lib/libc/hash/hashhl.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/lib/libc/hash/hashhl.c
diff -u src/lib/libc/hash/hashhl.c:1.3 src/lib/libc/hash/hashhl.c:1.4
--- src/lib/libc/hash/hashhl.c:1.3 Fri Mar 6 18:15:23 2009
+++ src/lib/libc/hash/hashhl.c Sun Jan 17 23:10:20 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: hashhl.c,v 1.3 2009/03/06 18:15:23 apb Exp $ */
+/* $NetBSD: hashhl.c,v 1.4 2010/01/17 23:10:20 wiz Exp $ */
/*
* ----------------------------------------------------------------------------
@@ -106,8 +106,10 @@
}
len = sb.st_size;
}
- if (off > 0 && lseek(fd, off, SEEK_SET) < 0)
+ if (off > 0 && lseek(fd, off, SEEK_SET) < 0) {
+ close(fd);
return (NULL);
+ }
while ((nr = read(fd, buffer, (size_t) MIN((off_t)sizeof(buffer), len)))
> 0) {
