Module Name: src Committed By: chs Date: Sun Jan 19 23:49:32 UTC 2020
Modified Files: src/sys/kern: subr_pool.c Log Message: fix assertions about when it is ok for pool_get() to return NULL. To generate a diff of this commit: cvs rdiff -u -r1.264 -r1.265 src/sys/kern/subr_pool.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/sys/kern/subr_pool.c diff -u src/sys/kern/subr_pool.c:1.264 src/sys/kern/subr_pool.c:1.265 --- src/sys/kern/subr_pool.c:1.264 Fri Dec 27 15:49:20 2019 +++ src/sys/kern/subr_pool.c Sun Jan 19 23:49:32 2020 @@ -1,4 +1,4 @@ -/* $NetBSD: subr_pool.c,v 1.264 2019/12/27 15:49:20 maxv Exp $ */ +/* $NetBSD: subr_pool.c,v 1.265 2020/01/19 23:49:32 chs Exp $ */ /* * Copyright (c) 1997, 1999, 2000, 2002, 2007, 2008, 2010, 2014, 2015, 2018 @@ -33,7 +33,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: subr_pool.c,v 1.264 2019/12/27 15:49:20 maxv Exp $"); +__KERNEL_RCSID(0, "$NetBSD: subr_pool.c,v 1.265 2020/01/19 23:49:32 chs Exp $"); #ifdef _KERNEL_OPT #include "opt_ddb.h" @@ -1145,7 +1145,7 @@ pool_get(struct pool *pp, int flags) pp->pr_nfail++; mutex_exit(&pp->pr_lock); - KASSERT((flags & (PR_WAITOK|PR_NOWAIT)) == PR_NOWAIT); + KASSERT((flags & (PR_NOWAIT|PR_LIMITFAIL)) != 0); return NULL; } @@ -2509,7 +2509,7 @@ pool_cache_get_slow(pool_cache_cpu_t *cc object = pool_get(&pc->pc_pool, flags); *objectp = object; if (__predict_false(object == NULL)) { - KASSERT((flags & (PR_WAITOK|PR_NOWAIT)) == PR_NOWAIT); + KASSERT((flags & (PR_NOWAIT|PR_LIMITFAIL)) != 0); return false; }