Module Name: src
Committed By: wiz
Date: Sun Jan 17 23:17:08 UTC 2010
Modified Files:
src/lib/libpam/modules/pam_nologin: pam_nologin.c
Log Message:
Close file handle after using it. Found by cppcheck.
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/lib/libpam/modules/pam_nologin/pam_nologin.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/lib/libpam/modules/pam_nologin/pam_nologin.c
diff -u src/lib/libpam/modules/pam_nologin/pam_nologin.c:1.7 src/lib/libpam/modules/pam_nologin/pam_nologin.c:1.8
--- src/lib/libpam/modules/pam_nologin/pam_nologin.c:1.7 Sun Jan 27 01:23:20 2008
+++ src/lib/libpam/modules/pam_nologin/pam_nologin.c Sun Jan 17 23:17:08 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: pam_nologin.c,v 1.7 2008/01/27 01:23:20 christos Exp $ */
+/* $NetBSD: pam_nologin.c,v 1.8 2010/01/17 23:17:08 wiz Exp $ */
/*-
* Copyright 2001 Mark R V Murray
@@ -40,7 +40,7 @@
#ifdef __FreeBSD__
__FBSDID("$FreeBSD: src/lib/libpam/modules/pam_nologin/pam_nologin.c,v 1.10 2002/04/12 22:27:21 des Exp $");
#else
-__RCSID("$NetBSD: pam_nologin.c,v 1.7 2008/01/27 01:23:20 christos Exp $");
+__RCSID("$NetBSD: pam_nologin.c,v 1.8 2010/01/17 23:17:08 wiz Exp $");
#endif
@@ -127,8 +127,10 @@
PAM_LOG("Opened %s file", nologin);
- if (fstat(fd, &st) < 0)
+ if (fstat(fd, &st) < 0) {
+ close(fd);
return PAM_AUTH_ERR;
+ }
mtmp = malloc(st.st_size + 1);
if (mtmp != NULL) {
@@ -137,6 +139,7 @@
pam_error(pamh, "%s", mtmp);
free(mtmp);
}
+ close(fd);
PAM_VERBOSE_ERROR("Administrator refusing you: %s", nologin);
