Module Name:    src
Committed By:   maxv
Date:           Sat Feb 22 08:39:33 UTC 2020

Modified Files:
        src/sys/kern: uipc_socket.c

Log Message:
Zero out 'tv', to prevent uninitialized bytes in its padding from leaking
to userland. Found by kMSan.

Reported-by: syzbot+8134380511a82c8f5...@syzkaller.appspotmail.com


To generate a diff of this commit:
cvs rdiff -u -r1.287 -r1.288 src/sys/kern/uipc_socket.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/kern/uipc_socket.c
diff -u src/sys/kern/uipc_socket.c:1.287 src/sys/kern/uipc_socket.c:1.288
--- src/sys/kern/uipc_socket.c:1.287	Fri Feb 21 00:26:22 2020
+++ src/sys/kern/uipc_socket.c	Sat Feb 22 08:39:33 2020
@@ -1,4 +1,4 @@
-/*	$NetBSD: uipc_socket.c,v 1.287 2020/02/21 00:26:22 joerg Exp $	*/
+/*	$NetBSD: uipc_socket.c,v 1.288 2020/02/22 08:39:33 maxv Exp $	*/
 
 /*
  * Copyright (c) 2002, 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -71,7 +71,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.287 2020/02/21 00:26:22 joerg Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.288 2020/02/22 08:39:33 maxv Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_compat_netbsd.h"
@@ -1992,6 +1992,7 @@ sogetopt1(struct socket *so, struct sock
 		optval = (opt == SO_SNDTIMEO ?
 		     so->so_snd.sb_timeo : so->so_rcv.sb_timeo);
 
+		memset(&tv, 0, sizeof(tv));
 		tv.tv_sec = optval / hz;
 		tv.tv_usec = (optval % hz) * tick;
 

Reply via email to