Module Name:    src
Committed By:   roy
Date:           Wed Mar 11 21:33:38 UTC 2020

Modified Files:
        src/lib/libcurses: initscr.c

Log Message:
curses: application should exit if initscr(3) fails

POSIX defines this behaviour here:
https://pubs.opengroup.org/onlinepubs/7908799/xcurses/initscr.html

Partial fix for PR lib/23910


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/lib/libcurses/initscr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/lib/libcurses/initscr.c
diff -u src/lib/libcurses/initscr.c:1.33 src/lib/libcurses/initscr.c:1.34
--- src/lib/libcurses/initscr.c:1.33	Tue Oct  2 17:35:44 2018
+++ src/lib/libcurses/initscr.c	Wed Mar 11 21:33:38 2020
@@ -1,4 +1,4 @@
-/*	$NetBSD: initscr.c,v 1.33 2018/10/02 17:35:44 roy Exp $	*/
+/*	$NetBSD: initscr.c,v 1.34 2020/03/11 21:33:38 roy Exp $	*/
 
 /*
  * Copyright (c) 1981, 1993, 1994
@@ -34,10 +34,11 @@
 #if 0
 static char sccsid[] = "@(#)initscr.c	8.2 (Berkeley) 5/4/94";
 #else
-__RCSID("$NetBSD: initscr.c,v 1.33 2018/10/02 17:35:44 roy Exp $");
+__RCSID("$NetBSD: initscr.c,v 1.34 2020/03/11 21:33:38 roy Exp $");
 #endif
 #endif	/* not lint */
 
+#include <err.h>
 #include <stdlib.h>
 
 #include "curses.h"
@@ -66,7 +67,7 @@ initscr(void)
 
 	/* LINTED const castaway; newterm does not modify sp! */
 	if ((_cursesi_screen = newterm((char *) sp, stdout, stdin)) == NULL)
-		return NULL;
+		errx(EXIT_FAILURE, "initscr"); /* POSIX says exit on failure */
 
 	set_term(_cursesi_screen);
 	wrefresh(curscr);

Reply via email to