Module Name: src
Committed By: nia
Date: Sun Apr 19 21:37:00 UTC 2020
Modified Files:
src/sys/compat/ossaudio: ossaudio.c
Log Message:
ossaudio: Avoid giving userland uninitialized memory. Noticed by maxv.
The uninitalized field in this structure is `fillers`, an array that
simply reserves space for later changes in OSSv4, which this version
of the OSS compat layer (specifically for Linux applications) makes no
effort to implement.
To generate a diff of this commit:
cvs rdiff -u -r1.82 -r1.83 src/sys/compat/ossaudio/ossaudio.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/compat/ossaudio/ossaudio.c
diff -u src/sys/compat/ossaudio/ossaudio.c:1.82 src/sys/compat/ossaudio/ossaudio.c:1.83
--- src/sys/compat/ossaudio/ossaudio.c:1.82 Sun Apr 19 13:44:51 2020
+++ src/sys/compat/ossaudio/ossaudio.c Sun Apr 19 21:37:00 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: ossaudio.c,v 1.82 2020/04/19 13:44:51 nia Exp $ */
+/* $NetBSD: ossaudio.c,v 1.83 2020/04/19 21:37:00 nia Exp $ */
/*-
* Copyright (c) 1997, 2008 The NetBSD Foundation, Inc.
@@ -27,7 +27,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ossaudio.c,v 1.82 2020/04/19 13:44:51 nia Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ossaudio.c,v 1.83 2020/04/19 21:37:00 nia Exp $");
#include <sys/param.h>
#include <sys/proc.h>
@@ -1103,6 +1103,7 @@ oss_ioctl_mixer(struct lwp *lwp, const s
__func__, error));
goto out;
}
+ memset(&omi, 0, sizeof omi);
omi.modify_counter = 1;
strncpy(omi.id, adev.name, sizeof omi.id);
strncpy(omi.name, adev.name, sizeof omi.name);
