Module Name: src
Committed By: jruoho
Date: Sat Jun 27 13:53:43 UTC 2020
Modified Files:
src/distrib/sets/lists/tests: mi
src/tests/sbin/ifconfig: Makefile
Added Files:
src/tests/sbin/ifconfig: t_random_garbage.sh
Log Message:
Add also a test that writes random garbage to every ifconfig(8) option that
takes parameters. Based on quick testing, iwn(4) and wm(4) pass, but
urtwn(4) panics. Use at your own risk; in some cases, it may be possible
that horrors are written directly to the hardware.
To generate a diff of this commit:
cvs rdiff -u -r1.860 -r1.861 src/distrib/sets/lists/tests/mi
cvs rdiff -u -r1.7 -r1.8 src/tests/sbin/ifconfig/Makefile
cvs rdiff -u -r0 -r1.1 src/tests/sbin/ifconfig/t_random_garbage.sh
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/distrib/sets/lists/tests/mi
diff -u src/distrib/sets/lists/tests/mi:1.860 src/distrib/sets/lists/tests/mi:1.861
--- src/distrib/sets/lists/tests/mi:1.860 Sat Jun 27 10:15:50 2020
+++ src/distrib/sets/lists/tests/mi Sat Jun 27 13:53:43 2020
@@ -1,4 +1,4 @@
-# $NetBSD: mi,v 1.860 2020/06/27 10:15:50 jruoho Exp $
+# $NetBSD: mi,v 1.861 2020/06/27 13:53:43 jruoho Exp $
#
# Note: don't delete entries from here - mark them as "obsolete" instead.
#
@@ -3999,6 +3999,7 @@
./usr/tests/sbin/ifconfig/t_bridge tests-sbin-tests compattestfile,atf
./usr/tests/sbin/ifconfig/t_capabilities tests-sbin-tests compattestfile,atf
./usr/tests/sbin/ifconfig/t_nonexistent tests-sbin-tests compattestfile,atf
+./usr/tests/sbin/ifconfig/t_random_garbage tests-sbin-tests compattestfile,atf
./usr/tests/sbin/ifconfig/t_repeated_scan tests-sbin-tests compattestfile,atf
./usr/tests/sbin/ifconfig/t_repeated_updown tests-sbin-tests compattestfile,atf
./usr/tests/sbin/ifconfig/t_tap tests-sbin-tests compattestfile,atf
Index: src/tests/sbin/ifconfig/Makefile
diff -u src/tests/sbin/ifconfig/Makefile:1.7 src/tests/sbin/ifconfig/Makefile:1.8
--- src/tests/sbin/ifconfig/Makefile:1.7 Sat Jun 27 06:57:44 2020
+++ src/tests/sbin/ifconfig/Makefile Sat Jun 27 13:53:43 2020
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.7 2020/06/27 06:57:44 jruoho Exp $
+# $NetBSD: Makefile,v 1.8 2020/06/27 13:53:43 jruoho Exp $
.include <bsd.own.mk>
@@ -7,6 +7,7 @@ TESTSDIR= ${TESTSBASE}/sbin/ifconfig
TESTS_SH= t_bridge \
t_capabilities \
t_nonexistent \
+ t_random_garbage \
t_repeated_scan \
t_repeated_updown \
t_tap \
Added files:
Index: src/tests/sbin/ifconfig/t_random_garbage.sh
diff -u /dev/null src/tests/sbin/ifconfig/t_random_garbage.sh:1.1
--- /dev/null Sat Jun 27 13:53:43 2020
+++ src/tests/sbin/ifconfig/t_random_garbage.sh Sat Jun 27 13:53:43 2020
@@ -0,0 +1,94 @@
+# $NetBSD: t_random_garbage.sh,v 1.1 2020/06/27 13:53:43 jruoho Exp $
+#
+# Copyright (c) 2020 The NetBSD Foundation, Inc.
+# All rights reserved.
+#
+# This code is derived from software contributed to The NetBSD Foundation
+# by Jukka Ruohonen.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
+# ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
+# TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
+# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+# POSSIBILITY OF SUCH DAMAGE.
+#
+getrint() {
+ echo $(od -An -N2 -i /dev/urandom | sed 's/ //')
+}
+
+getrstr() {
+ echo $(cat /dev/urandom | head -n 1 | base64)
+}
+
+write_garbage() {
+ val=$(getrint)
+ echo "Test $3: write to $1 opt $2 -> $val"
+ ifconfig $1 $opt $val >/dev/null 2>&1
+ val=$(getrstr)
+ echo "Test $3: write to $1 opt $2 -> $val"
+ ifconfig $1 $opt $val >/dev/null 2>&1
+}
+
+atf_test_case random_garbage
+random_garbage_head() {
+ atf_set "require.user" "root"
+ atf_set "descr" "Test writing random garbage to ifconfig(8) options"
+}
+
+random_garbage_body() {
+
+ # Please note:
+ #
+ # 1. As some drivers seem to have input validation issues, it may
+ # be possible that horrors are written directly to the hardware.
+ #
+ # 2. Even if the test passes, there is no easy way to restore
+ # the existing state/configuration of any given interface.
+ #
+ # Take care.
+ #
+ atf_skip "The test is not safe"
+
+ opts="advbase advskew broadcast carpdev description \
+ media mediaopt -mediaopt mode instance metric mtu \
+ netmask state frag rts ssid nwid nwkey pass powersavesleep \
+ bssid chan tunnel session cookie pltime prefixlen linkstr \
+ vhid vlan vlanif -vlanif agrport -agrport vltime maxupd \
+ syncdev syncpeer"
+
+ for i in $(ifconfig -l); do
+
+ ifconfig $i up
+
+ for o in $opts; do
+
+ n=10
+
+ while [ $n -gt 0 ]; do
+ write_garbage $i $o $n
+ n=$(expr $n - 1)
+ done
+ done
+ done
+
+ atf_pass
+}
+
+atf_init_test_cases() {
+ atf_add_test_case random_garbage
+}
