Module Name: src
Committed By: kim
Date: Sun Jul 12 06:40:11 UTC 2020
Modified Files:
src/sys/dev/pci: vioscsi.c
Log Message:
Fix off-by-one SCSI target reporting
Use max_target as the controller ID instead of zero, so that the device
located at SCSI ID zero (e.g. a disk) is not obscured through not being
probed by scsi_probe_bus() (which skips the controller ID).
Copy the target requested onto the wire without decrementing it by one.
ok christos@
To generate a diff of this commit:
cvs rdiff -u -r1.21 -r1.22 src/sys/dev/pci/vioscsi.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/pci/vioscsi.c
diff -u src/sys/dev/pci/vioscsi.c:1.21 src/sys/dev/pci/vioscsi.c:1.22
--- src/sys/dev/pci/vioscsi.c:1.21 Sat Apr 13 06:17:33 2019
+++ src/sys/dev/pci/vioscsi.c Sun Jul 12 06:40:11 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: vioscsi.c,v 1.21 2019/04/13 06:17:33 maxv Exp $ */
+/* $NetBSD: vioscsi.c,v 1.22 2020/07/12 06:40:11 kim Exp $ */
/* $OpenBSD: vioscsi.c,v 1.3 2015/03/14 03:38:49 jsg Exp $ */
/*
@@ -18,7 +18,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: vioscsi.c,v 1.21 2019/04/13 06:17:33 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: vioscsi.c,v 1.22 2020/07/12 06:40:11 kim Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@@ -194,7 +194,7 @@ vioscsi_attach(device_t parent, device_t
chan->chan_channel = 0;
chan->chan_ntargets = MIN(max_target, 16); /* cap reasonably */
chan->chan_nluns = MIN(max_lun, 1024); /* cap reasonably */
- chan->chan_id = 0;
+ chan->chan_id = max_target;
chan->chan_flags = SCSIPI_CHAN_NOSETTLE;
config_found(self, &sc->sc_channel, scsiprint);
@@ -318,7 +318,7 @@ vioscsi_scsipi_request(struct scsipi_cha
}
req->lun[0] = 1;
- req->lun[1] = periph->periph_target - 1;
+ req->lun[1] = periph->periph_target;
req->lun[2] = 0x40 | ((periph->periph_lun >> 8) & 0x3F);
req->lun[3] = periph->periph_lun & 0xFF;
memset(req->lun + 4, 0, 4);
