Module Name: src
Committed By: rillig
Date: Fri Aug 21 14:33:32 UTC 2020
Modified Files:
src/usr.bin/make: lst.c
Log Message:
make(1): revert invalid assertion
When iterating over a list, it is currently not guaranteed that the list
is marked as "!isOpen", which I had wrongly and naively assumed.
This probably means that there is some hidden bug in make, but even if
there is, this bug would be quite old already and was too small to be
detected.
Therefore, remove the assertion again, until the situation is clear and
reproduced.
To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/usr.bin/make/lst.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/lst.c
diff -u src/usr.bin/make/lst.c:1.17 src/usr.bin/make/lst.c:1.18
--- src/usr.bin/make/lst.c:1.17 Fri Aug 21 07:04:31 2020
+++ src/usr.bin/make/lst.c Fri Aug 21 14:33:32 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: lst.c,v 1.17 2020/08/21 07:04:31 rillig Exp $ */
+/* $NetBSD: lst.c,v 1.18 2020/08/21 14:33:32 rillig Exp $ */
/*
* Copyright (c) 1988, 1989, 1990, 1993
@@ -38,11 +38,11 @@
#include "make_malloc.h"
#ifndef MAKE_NATIVE
-static char rcsid[] = "$NetBSD: lst.c,v 1.17 2020/08/21 07:04:31 rillig Exp $";
+static char rcsid[] = "$NetBSD: lst.c,v 1.18 2020/08/21 14:33:32 rillig Exp $";
#else
#include <sys/cdefs.h>
#ifndef lint
-__RCSID("$NetBSD: lst.c,v 1.17 2020/08/21 07:04:31 rillig Exp $");
+__RCSID("$NetBSD: lst.c,v 1.18 2020/08/21 14:33:32 rillig Exp $");
#endif /* not lint */
#endif
@@ -656,7 +656,6 @@ void
Lst_OpenS(Lst list)
{
assert(LstValid(list));
- assert(!list->isOpen);
list->isOpen = TRUE;
list->lastAccess = LstIsEmpty(list) ? Head : Unknown;
