Module Name:    src
Committed By:   rillig
Date:           Thu Nov  5 15:04:51 UTC 2020

Modified Files:
        src/usr.bin/make: var.c

Log Message:
make(1): remove wrong comment from Var_Subst

The error handling in variable expressions is inconsistent.  Some errors
are detected, most aren't.  In particular, the error message for
undefined variables is _not_ issued on undefined variables but instead
on parse errors.


To generate a diff of this commit:
cvs rdiff -u -r1.657 -r1.658 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/usr.bin/make/var.c
diff -u src/usr.bin/make/var.c:1.657 src/usr.bin/make/var.c:1.658
--- src/usr.bin/make/var.c:1.657	Wed Nov  4 04:49:32 2020
+++ src/usr.bin/make/var.c	Thu Nov  5 15:04:51 2020
@@ -1,4 +1,4 @@
-/*	$NetBSD: var.c,v 1.657 2020/11/04 04:49:32 rillig Exp $	*/
+/*	$NetBSD: var.c,v 1.658 2020/11/05 15:04:51 rillig Exp $	*/
 
 /*
  * Copyright (c) 1988, 1989, 1990, 1993
@@ -130,7 +130,7 @@
 #include "metachar.h"
 
 /*	"@(#)var.c	8.3 (Berkeley) 3/19/94" */
-MAKE_RCSID("$NetBSD: var.c,v 1.657 2020/11/04 04:49:32 rillig Exp $");
+MAKE_RCSID("$NetBSD: var.c,v 1.658 2020/11/05 15:04:51 rillig Exp $");
 
 #define VAR_DEBUG1(fmt, arg1) DEBUG1(VAR, fmt, arg1)
 #define VAR_DEBUG2(fmt, arg1, arg2) DEBUG2(VAR, fmt, arg1, arg2)
@@ -3937,9 +3937,6 @@ Var_Parse(const char **pp, GNode *ctxt, 
 
 /* Substitute for all variables in the given string in the given context.
  *
- * If eflags & VARE_UNDEFERR, Parse_Error will be called when an undefined
- * variable is encountered.
- *
  * If eflags & VARE_WANTRES, any effects from the modifiers, such as ::=,
  * :sh or !cmd! take place.
  *

Reply via email to