Module Name: src
Committed By: rillig
Date: Wed Nov 11 07:30:11 UTC 2020
Modified Files:
src/usr.bin/make/unit-tests: cond-cmp-unary.exp cond-cmp-unary.mk
Log Message:
make(1): add tests demonstrating bugs in TryParseNumber and EvalNotEmpty
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/usr.bin/make/unit-tests/cond-cmp-unary.exp \
src/usr.bin/make/unit-tests/cond-cmp-unary.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/unit-tests/cond-cmp-unary.exp
diff -u src/usr.bin/make/unit-tests/cond-cmp-unary.exp:1.1 src/usr.bin/make/unit-tests/cond-cmp-unary.exp:1.2
--- src/usr.bin/make/unit-tests/cond-cmp-unary.exp:1.1 Mon Sep 14 06:22:59 2020
+++ src/usr.bin/make/unit-tests/cond-cmp-unary.exp Wed Nov 11 07:30:11 2020
@@ -1 +1,2 @@
+make: "cond-cmp-unary.mk" line 53: This is only reached because of a bug in EvalNotEmpty.
exit status 0
Index: src/usr.bin/make/unit-tests/cond-cmp-unary.mk
diff -u src/usr.bin/make/unit-tests/cond-cmp-unary.mk:1.1 src/usr.bin/make/unit-tests/cond-cmp-unary.mk:1.2
--- src/usr.bin/make/unit-tests/cond-cmp-unary.mk:1.1 Mon Sep 14 06:22:59 2020
+++ src/usr.bin/make/unit-tests/cond-cmp-unary.mk Wed Nov 11 07:30:11 2020
@@ -1,4 +1,4 @@
-# $NetBSD: cond-cmp-unary.mk,v 1.1 2020/09/14 06:22:59 rillig Exp $
+# $NetBSD: cond-cmp-unary.mk,v 1.2 2020/11/11 07:30:11 rillig Exp $
#
# Tests for unary comparisons in .if conditions, that is, comparisons with
# a single operand. If the operand is a number, it is compared to zero,
@@ -25,6 +25,9 @@
.endif
# The empty string may come from a variable expression.
+#
+# XXX: As of 2020-11-11, this empty string is interpreted "as a number" in
+# EvalNotEmpty, which is plain wrong. The bug is in TryParseNumber.
.if ${:U}
. error
.endif
@@ -40,4 +43,16 @@
. error
.endif
+# A string of whitespace should evaluate to false.
+#
+# XXX: As of 2020-11-11, the implementation in EvalNotEmpty does not skip
+# whitespace before testing for the end. This was probably an oversight in
+# a commit from 1992-04-15 saying "A variable is empty when it just contains
+# spaces".
+.if ${:U }
+. info This is only reached because of a bug in EvalNotEmpty.
+.else
+. error
+.endif
+
all: # nothing
