Module Name: src
Committed By: rillig
Date: Fri Dec 11 22:33:06 UTC 2020
Modified Files:
src/usr.bin/make: job.c
Log Message:
make(1): mark strange code that calls exit(signo)
In other places, the exit status of make is carefully chosen to be 0
(success), 1 (did not make everything), 2 (other error). Using a signal
number is not guaranteed to be consistent among operating systems and is
therefore a weird choice.
To generate a diff of this commit:
cvs rdiff -u -r1.367 -r1.368 src/usr.bin/make/job.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/job.c
diff -u src/usr.bin/make/job.c:1.367 src/usr.bin/make/job.c:1.368
--- src/usr.bin/make/job.c:1.367 Fri Dec 11 01:08:51 2020
+++ src/usr.bin/make/job.c Fri Dec 11 22:33:06 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: job.c,v 1.367 2020/12/11 01:08:51 rillig Exp $ */
+/* $NetBSD: job.c,v 1.368 2020/12/11 22:33:06 rillig Exp $ */
/*
* Copyright (c) 1988, 1989, 1990 The Regents of the University of California.
@@ -143,7 +143,7 @@
#include "trace.h"
/* "@(#)job.c 8.2 (Berkeley) 3/19/94" */
-MAKE_RCSID("$NetBSD: job.c,v 1.367 2020/12/11 01:08:51 rillig Exp $");
+MAKE_RCSID("$NetBSD: job.c,v 1.368 2020/12/11 22:33:06 rillig Exp $");
/*
* A shell defines how the commands are run. All commands for a target are
@@ -2506,7 +2506,7 @@ JobInterrupt(int runINTERRUPT, int signo
}
}
Trace_Log(MAKEINTR, NULL);
- exit(signo);
+ exit(signo); /* XXX: why signo? */
}
/*
