Module Name:    src
Committed By:   rillig
Date:           Mon Feb 22 22:34:04 UTC 2021

Modified Files:
        src/usr.bin/make: var.c

Log Message:
make: add a few open questions to Var_SetWithFlags


To generate a diff of this commit:
cvs rdiff -u -r1.835 -r1.836 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/usr.bin/make/var.c
diff -u src/usr.bin/make/var.c:1.835 src/usr.bin/make/var.c:1.836
--- src/usr.bin/make/var.c:1.835	Mon Feb 22 22:26:50 2021
+++ src/usr.bin/make/var.c	Mon Feb 22 22:34:04 2021
@@ -1,4 +1,4 @@
-/*	$NetBSD: var.c,v 1.835 2021/02/22 22:26:50 rillig Exp $	*/
+/*	$NetBSD: var.c,v 1.836 2021/02/22 22:34:04 rillig Exp $	*/
 
 /*
  * Copyright (c) 1988, 1989, 1990, 1993
@@ -140,7 +140,7 @@
 #include "metachar.h"
 
 /*	"@(#)var.c	8.3 (Berkeley) 3/19/94" */
-MAKE_RCSID("$NetBSD: var.c,v 1.835 2021/02/22 22:26:50 rillig Exp $");
+MAKE_RCSID("$NetBSD: var.c,v 1.836 2021/02/22 22:34:04 rillig Exp $");
 
 typedef enum VarFlags {
 	VFL_NONE	= 0,
@@ -1020,6 +1020,9 @@ Var_SetWithFlags(GNode *scope, const cha
 		 */
 		if (!opts.varNoExportEnv)
 			setenv(name, val, 1);
+		/* XXX: What about .MAKE.EXPORTED? */
+		/* XXX: Why not just mark the variable for needing export,
+		 *  as in ExportVarPlain? */
 
 		Global_Append(MAKEOVERRIDES, name);
 	}

Reply via email to