Module Name: src
Committed By: rillig
Date: Tue Jun 29 14:19:51 UTC 2021
Modified Files:
src/tests/usr.bin/xlint/lint1: lex_char_uchar.c lex_char_uchar.exp
src/usr.bin/xlint/lint1: tree.c
Log Message:
lint: document where to fix the wrong warning for '\xff'
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/usr.bin/xlint/lint1/lex_char_uchar.c \
src/tests/usr.bin/xlint/lint1/lex_char_uchar.exp
cvs rdiff -u -r1.295 -r1.296 src/usr.bin/xlint/lint1/tree.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/usr.bin/xlint/lint1/lex_char_uchar.c
diff -u src/tests/usr.bin/xlint/lint1/lex_char_uchar.c:1.1 src/tests/usr.bin/xlint/lint1/lex_char_uchar.c:1.2
--- src/tests/usr.bin/xlint/lint1/lex_char_uchar.c:1.1 Tue Jun 29 13:58:13 2021
+++ src/tests/usr.bin/xlint/lint1/lex_char_uchar.c Tue Jun 29 14:19:51 2021
@@ -1,4 +1,4 @@
-/* $NetBSD: lex_char_uchar.c,v 1.1 2021/06/29 13:58:13 rillig Exp $ */
+/* $NetBSD: lex_char_uchar.c,v 1.2 2021/06/29 14:19:51 rillig Exp $ */
# 3 "lex_char_uchar.c"
/*
@@ -11,6 +11,7 @@
/*
* FIXME: The warning is bogus; it must be possible to initialize a char
* variable with a character constant.
+ * See tree.c, function convert_constant.
*/
/* expect+1: conversion of 'int' to 'char' is out of range [119] */
char ch = '\xff';
Index: src/tests/usr.bin/xlint/lint1/lex_char_uchar.exp
diff -u src/tests/usr.bin/xlint/lint1/lex_char_uchar.exp:1.1 src/tests/usr.bin/xlint/lint1/lex_char_uchar.exp:1.2
--- src/tests/usr.bin/xlint/lint1/lex_char_uchar.exp:1.1 Tue Jun 29 13:58:13 2021
+++ src/tests/usr.bin/xlint/lint1/lex_char_uchar.exp Tue Jun 29 14:19:51 2021
@@ -1 +1 @@
-lex_char_uchar.c(16): warning: conversion of 'int' to 'char' is out of range [119]
+lex_char_uchar.c(17): warning: conversion of 'int' to 'char' is out of range [119]
Index: src/usr.bin/xlint/lint1/tree.c
diff -u src/usr.bin/xlint/lint1/tree.c:1.295 src/usr.bin/xlint/lint1/tree.c:1.296
--- src/usr.bin/xlint/lint1/tree.c:1.295 Tue Jun 29 10:12:35 2021
+++ src/usr.bin/xlint/lint1/tree.c Tue Jun 29 14:19:51 2021
@@ -1,4 +1,4 @@
-/* $NetBSD: tree.c,v 1.295 2021/06/29 10:12:35 rillig Exp $ */
+/* $NetBSD: tree.c,v 1.296 2021/06/29 14:19:51 rillig Exp $ */
/*
* Copyright (c) 1994, 1995 Jochen Pohl
@@ -37,7 +37,7 @@
#include <sys/cdefs.h>
#if defined(__RCSID) && !defined(lint)
-__RCSID("$NetBSD: tree.c,v 1.295 2021/06/29 10:12:35 rillig Exp $");
+__RCSID("$NetBSD: tree.c,v 1.296 2021/06/29 14:19:51 rillig Exp $");
#endif
#include <float.h>
@@ -2410,6 +2410,11 @@ convert_constant(op_t op, int arg, const
case LCOMPLEX:
break;
default:
+ /*
+ * FIXME: There must be no sign extension when converting
+ * from int to char on a platform where char == unsigned
+ * char. See test lex_char_uchar.c.
+ */
sz = tp->t_bitfield ? tp->t_flen : size_in_bits(nt);
nv->v_quad = xsign(nv->v_quad, nt, sz);
break;
