Module Name:    src
Committed By:   uebayasi
Date:           Wed Aug 25 14:29:12 UTC 2010

Modified Files:
        src/sys/miscfs/genfs [uebayasi-xip]: genfs_io.c

Log Message:
Fix UVMHIST build.

Remove a comment about xip getpages optimization; quick profiling showed
that this routine is not expensive.  It'd be better to concentrate on
reducing TLB miss.


To generate a diff of this commit:
cvs rdiff -u -r1.36.2.21 -r1.36.2.22 src/sys/miscfs/genfs/genfs_io.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/miscfs/genfs/genfs_io.c
diff -u src/sys/miscfs/genfs/genfs_io.c:1.36.2.21 src/sys/miscfs/genfs/genfs_io.c:1.36.2.22
--- src/sys/miscfs/genfs/genfs_io.c:1.36.2.21	Tue Aug 17 06:47:36 2010
+++ src/sys/miscfs/genfs/genfs_io.c	Wed Aug 25 14:29:12 2010
@@ -1,4 +1,4 @@
-/*	$NetBSD: genfs_io.c,v 1.36.2.21 2010/08/17 06:47:36 uebayasi Exp $	*/
+/*	$NetBSD: genfs_io.c,v 1.36.2.22 2010/08/25 14:29:12 uebayasi Exp $	*/
 
 /*
  * Copyright (c) 1982, 1986, 1989, 1993
@@ -31,7 +31,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: genfs_io.c,v 1.36.2.21 2010/08/17 06:47:36 uebayasi Exp $");
+__KERNEL_RCSID(0, "$NetBSD: genfs_io.c,v 1.36.2.22 2010/08/25 14:29:12 uebayasi Exp $");
 
 #include "opt_xip.h"
 
@@ -824,7 +824,6 @@
 	if ((flags & PGO_LOCKED) == 0)
 		mutex_exit(&uobj->vmobjlock);
 
-	/* XXX optimize */
 	off = offset;
 	for (i = 0; i < npages; i++) {
 		daddr_t lbn, blkno;
@@ -867,7 +866,7 @@
 
 		UVMHIST_LOG(ubchist, "xip pgs %d => phys_addr=0x%lx (%p)",
 			i,
-			(long)pg->phys_addr,
+			(long)pps[i]->phys_addr,
 			pps[i],
 			0);
 

Reply via email to