Module Name:    src
Committed By:   jmcneill
Date:           Tue Oct 19 22:27:19 UTC 2010

Modified Files:
        src/sys/dev/ic: pcdisplay_subr.c

Log Message:
When disabling the hardware cursor, use the 'cursor disable' bit in the
cursor start register. I think this only accidentally worked for the past
11 years because the start and end scanlines were both set to 0x10.

See also http://www.osdever.net/FreeVGA/vga/crtcreg.htm#0A


To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 src/sys/dev/ic/pcdisplay_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/dev/ic/pcdisplay_subr.c
diff -u src/sys/dev/ic/pcdisplay_subr.c:1.34 src/sys/dev/ic/pcdisplay_subr.c:1.35
--- src/sys/dev/ic/pcdisplay_subr.c:1.34	Fri Oct 19 11:59:58 2007
+++ src/sys/dev/ic/pcdisplay_subr.c	Tue Oct 19 22:27:19 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: pcdisplay_subr.c,v 1.34 2007/10/19 11:59:58 ad Exp $ */
+/* $NetBSD: pcdisplay_subr.c,v 1.35 2010/10/19 22:27:19 jmcneill Exp $ */
 
 /*
  * Copyright (c) 1995, 1996 Carnegie-Mellon University.
@@ -28,7 +28,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: pcdisplay_subr.c,v 1.34 2007/10/19 11:59:58 ad Exp $");
+__KERNEL_RCSID(0, "$NetBSD: pcdisplay_subr.c,v 1.35 2010/10/19 22:27:19 jmcneill Exp $");
 
 #include "opt_wsmsgattrs.h" /* for WSDISPLAY_CUSTOM_OUTPUT */
 
@@ -51,8 +51,9 @@
 	bus_space_handle_t memh;
 	int off;
 
-	pcdisplay_6845_write(scr->hdl, curstart, 0x10);
-	pcdisplay_6845_write(scr->hdl, curend, 0x10);
+	/* Disable the hardware cursor */
+	pcdisplay_6845_write(scr->hdl, curstart, 0x20);
+	pcdisplay_6845_write(scr->hdl, curend, 0x00);
 
 	if (existing) {
 		/*

Reply via email to