Module Name:    src
Committed By:   hannken
Date:           Tue Jun 21 12:38:28 UTC 2011

Modified Files:
        src/sys/dev/i2c: ibmhawk.c

Log Message:
Make sure sensor state is valid before calling sysmon_envsys_sensor_attach().

Ok: Paul Goyette <pgoye...@netbsd.org>


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/dev/i2c/ibmhawk.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/dev/i2c/ibmhawk.c
diff -u src/sys/dev/i2c/ibmhawk.c:1.2 src/sys/dev/i2c/ibmhawk.c:1.3
--- src/sys/dev/i2c/ibmhawk.c:1.2	Mon Feb 14 14:15:25 2011
+++ src/sys/dev/i2c/ibmhawk.c	Tue Jun 21 12:38:27 2011
@@ -1,4 +1,4 @@
-/* $NetBSD: ibmhawk.c,v 1.2 2011/02/14 14:15:25 hannken Exp $ */
+/* $NetBSD: ibmhawk.c,v 1.3 2011/06/21 12:38:27 hannken Exp $ */
 
 /*-
  * Copyright (c) 2011 The NetBSD Foundation, Inc.
@@ -313,9 +313,6 @@
 			    ibmhawk_normalize(sd->ihs_warnmax, dp->units);
 			dp->flags |= ENVSYS_FMONLIMITS;
 		}
-		if (sysmon_envsys_sensor_attach(sc->sc_sme, dp))
-			aprint_error_dev(sc->sc_dev,
-			    "failed to attach \"%s\"\n", dp->desc);
 	}
 
 	if (valid) {
@@ -323,6 +320,12 @@
 		dp->state = ENVSYS_SVALID;
 	} else
 		dp->state = ENVSYS_SINVALID;
+
+	if (create) {
+		if (sysmon_envsys_sensor_attach(sc->sc_sme, dp))
+			aprint_error_dev(sc->sc_dev,
+			    "failed to attach \"%s\"\n", dp->desc);
+	}
 }
 
 static void

Reply via email to