Module Name:    src
Committed By:   mrg
Date:           Wed Jun 22 04:01:33 UTC 2011

Modified Files:
        src/sys/ufs/ffs: ffs_appleufs.c

Log Message:
fix an off by one array overflow found by GCC 4.5.3.


To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/sys/ufs/ffs/ffs_appleufs.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/ufs/ffs/ffs_appleufs.c
diff -u src/sys/ufs/ffs/ffs_appleufs.c:1.10 src/sys/ufs/ffs/ffs_appleufs.c:1.11
--- src/sys/ufs/ffs/ffs_appleufs.c:1.10	Sat Apr 24 19:58:13 2010
+++ src/sys/ufs/ffs/ffs_appleufs.c	Wed Jun 22 04:01:33 2011
@@ -1,4 +1,4 @@
-/*	$NetBSD: ffs_appleufs.c,v 1.10 2010/04/24 19:58:13 dbj Exp $	*/
+/*	$NetBSD: ffs_appleufs.c,v 1.11 2011/06/22 04:01:33 mrg Exp $	*/
 
 /*
  * Copyright (c) 2002 Darrin B. Jewell
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ffs_appleufs.c,v 1.10 2010/04/24 19:58:13 dbj Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ffs_appleufs.c,v 1.11 2011/06/22 04:01:33 mrg Exp $");
 
 #include <sys/param.h>
 #include <sys/time.h>
@@ -108,7 +108,7 @@
 		n->ul_namelen = APPLEUFS_MAX_LABEL_NAME;
 	}
 	/* if len is max, will set ul_unused1 */
-	n->ul_name[n->ul_namelen] = '\0';
+	n->ul_name[n->ul_namelen - 1] = '\0';
 
 #ifdef DEBUG
 	printf("%s: found APPLE UFS label v%d: \"%s\"\n",

Reply via email to