CVS commit: src/lib/libedit

[Christos Zoulas]

Module Name:    src
Committed By:   christos
Date:           Fri Nov 18 20:24:21 UTC 2011

Modified Files:
        src/lib/libedit: vi.c

Log Message:
Off by one in allocation could cause buffer overflow (Kamil Dudka)


To generate a diff of this commit:
cvs rdiff -u -r1.41 -r1.42 src/lib/libedit/vi.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


Modified files:

Index: src/lib/libedit/vi.c
diff -u src/lib/libedit/vi.c:1.41 src/lib/libedit/vi.c:1.42
--- src/lib/libedit/vi.c:1.41	Tue Oct  4 11:27:04 2011
+++ src/lib/libedit/vi.c	Fri Nov 18 15:24:21 2011
@@ -1,4 +1,4 @@
-/*	$NetBSD: vi.c,v 1.41 2011/10/04 15:27:04 christos Exp $	*/
+/*	$NetBSD: vi.c,v 1.42 2011/11/18 20:24:21 christos Exp $	*/
 
 /*-
  * Copyright (c) 1992, 1993
@@ -42,7 +42,7 @@
 #if 0
 static char sccsid[] = "@(#)vi.c	8.1 (Berkeley) 6/4/93";
 #else
-__RCSID("$NetBSD: vi.c,v 1.41 2011/10/04 15:27:04 christos Exp $");
+__RCSID("$NetBSD: vi.c,v 1.42 2011/11/18 20:24:21 christos Exp $");
 #endif
 #endif /* not lint && not SCCSID */
 
@@ -1026,7 +1026,7 @@ vi_histedit(EditLine *el, Int c __attrib
 		close(fd);
 		return CC_ERROR;
 	}
-	line = el_malloc(len * sizeof(*line));
+	line = el_malloc(len * sizeof(*line) + 1);
 	if (line == NULL) {
 		el_free(cp);
 		return CC_ERROR;