Module Name:    src
Committed By:   christos
Date:           Sat Dec 24 23:46:11 UTC 2011

Modified Files:
        src/usr.sbin/catman: catman.c

Log Message:
make len unsigned; -1 will turn into a large number, failing the test.


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/usr.sbin/catman/catman.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/usr.sbin/catman/catman.c
diff -u src/usr.sbin/catman/catman.c:1.33 src/usr.sbin/catman/catman.c:1.34
--- src/usr.sbin/catman/catman.c:1.33	Sat Dec 24 18:42:30 2011
+++ src/usr.sbin/catman/catman.c	Sat Dec 24 18:46:11 2011
@@ -1,4 +1,4 @@
-/*      $NetBSD: catman.c,v 1.33 2011/12/24 23:42:30 christos Exp $       */
+/*      $NetBSD: catman.c,v 1.34 2011/12/24 23:46:11 christos Exp $       */
 
 /*
  * Copyright (c) 1998 The NetBSD Foundation, Inc.
@@ -561,10 +561,10 @@ makecat(const char *manpage, const char 
 {
 	char crunchbuf[1024];
 	char sysbuf[2048];
-	int len;
+	size_t len;
 
 	len = snprintf(sysbuf, sizeof(sysbuf), buildcmd, manpage);
-	if (len < 0 || len > sizeof(sysbuf))
+	if (len > sizeof(sysbuf))
 		errx(1, "snprintf");
 
 	if (*crunchcmd != '\0') {

Reply via email to