Module Name: src
Committed By: dsl
Date: Sat Dec 15 22:39:04 UTC 2012
Modified Files:
src/sys/arch/amd64/include: mcontext.h
Log Message:
Remove the incorrect comment about a (now deleted) pad field added
to make __fpregs be 16-byte aligned within ucontext_t.
I doubt that has been true for years!
Since the __fpregs field isn't accessed by fxsave it doesn't matter.
There is a lot of type fubar here, at leat mark the char[] __aligned(8).
To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/sys/arch/amd64/include/mcontext.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/arch/amd64/include/mcontext.h
diff -u src/sys/arch/amd64/include/mcontext.h:1.15 src/sys/arch/amd64/include/mcontext.h:1.16
--- src/sys/arch/amd64/include/mcontext.h:1.15 Mon May 21 14:15:17 2012
+++ src/sys/arch/amd64/include/mcontext.h Sat Dec 15 22:39:04 2012
@@ -1,4 +1,4 @@
-/* $NetBSD: mcontext.h,v 1.15 2012/05/21 14:15:17 martin Exp $ */
+/* $NetBSD: mcontext.h,v 1.16 2012/12/15 22:39:04 dsl Exp $ */
/*-
* Copyright (c) 1999 The NetBSD Foundation, Inc.
@@ -52,13 +52,11 @@ typedef __greg_t __gregset_t[_NGREG];
/*
* Floating point register state
+ * The format of __fpregset_t is that of the fxsave instruction
+ * which requires 16 byte alignment. However the mcontext version
+ * is never directly accessed.
*/
-typedef char __fpregset_t[512];
-
-/*
- * The padding below is to make __fpregs have a 16-byte aligned offset
- * within ucontext_t.
- */
+typedef char __fpregset_t[512] __aligned(8);
typedef struct {
__gregset_t __gregs;
