Module Name: src
Committed By: riastradh
Date: Wed Jul 24 02:38:23 UTC 2013
Modified Files:
src/sys/external/bsd/drm2/drm [riastradh-drm2]: drm_lock.c
Log Message:
Add comment explaining why drm_idlelock_* are not yet implemented.
To generate a diff of this commit:
cvs rdiff -u -r1.1.2.2 -r1.1.2.3 src/sys/external/bsd/drm2/drm/drm_lock.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/external/bsd/drm2/drm/drm_lock.c
diff -u src/sys/external/bsd/drm2/drm/drm_lock.c:1.1.2.2 src/sys/external/bsd/drm2/drm/drm_lock.c:1.1.2.3
--- src/sys/external/bsd/drm2/drm/drm_lock.c:1.1.2.2 Wed Jul 24 02:35:35 2013
+++ src/sys/external/bsd/drm2/drm/drm_lock.c Wed Jul 24 02:38:23 2013
@@ -1,4 +1,4 @@
-/* $NetBSD: drm_lock.c,v 1.1.2.2 2013/07/24 02:35:35 riastradh Exp $ */
+/* $NetBSD: drm_lock.c,v 1.1.2.3 2013/07/24 02:38:23 riastradh Exp $ */
/*-
* Copyright (c) 2013 The NetBSD Foundation, Inc.
@@ -43,7 +43,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: drm_lock.c,v 1.1.2.2 2013/07/24 02:35:35 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: drm_lock.c,v 1.1.2.3 2013/07/24 02:38:23 riastradh Exp $");
#include <sys/types.h>
#include <sys/errno.h>
@@ -209,6 +209,11 @@ drm_lock_free(struct drm_lock_data *lock
/*
* Take the lock for the kernel's use.
+ *
+ * XXX This is unimplemented because it's not clear that the Linux code
+ * makes sense at all. Linux's drm_idlelock_take never blocks, but it
+ * doesn't guarantee that the kernel holds the lock on return! For
+ * now, I'll hope that the code paths relying on this don't matter yet.
*/
void
drm_idlelock_take(struct drm_lock_data *lock_data __unused)
