Module Name: src
Committed By: dsainty
Date: Wed Sep 25 03:28:21 UTC 2013
Modified Files:
src/lib/libcurses: setterm.c
Log Message:
Fix a NULL dereference if the exit_alt_charset_mode capability is not defined.
The previous version of this file changed a terminal initialisation test on
the exit_attribute_mode capability, checking for the exit_alt_charset_mode
capability as a substring, rather than performing a search for the hard-coded
^O character.
That works better on terminals where ^O is not the correct value for
exit_alt_charset_mode. But it works worse on terminals that don't have a
definition specified for exit_alt_charset_mode.
For example:
% TERMCAP='xterm:me=\E[m:' TERM=xterm vi
segmentation fault (core dumped) TERMCAP='xterm:me=\E[m:' TERM=xterm vi
The crash can be avoided (without fixing the bug) by defining
exit_alt_charset_mode:
% TERMCAP='xterm|:me=\E[m:ae=:' TERM=xterm vi
ex/vi: Error: xterm: No such process
We now test exit_alt_charset_mode for NULL before continuing with the fatal
test, restoring the original no-crash behaviour.
XXX does_ctrl_o() is now just a naive reimplementation of strstr(), so should
probably just use strstr() instead.
To generate a diff of this commit:
cvs rdiff -u -r1.50 -r1.51 src/lib/libcurses/setterm.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/lib/libcurses/setterm.c
diff -u src/lib/libcurses/setterm.c:1.50 src/lib/libcurses/setterm.c:1.51
--- src/lib/libcurses/setterm.c:1.50 Sun May 5 14:24:05 2013
+++ src/lib/libcurses/setterm.c Wed Sep 25 03:28:20 2013
@@ -1,4 +1,4 @@
-/* $NetBSD: setterm.c,v 1.50 2013/05/05 14:24:05 jdc Exp $ */
+/* $NetBSD: setterm.c,v 1.51 2013/09/25 03:28:20 dsainty Exp $ */
/*
* Copyright (c) 1981, 1993, 1994
@@ -34,7 +34,7 @@
#if 0
static char sccsid[] = "@(#)setterm.c 8.8 (Berkeley) 10/25/94";
#else
-__RCSID("$NetBSD: setterm.c,v 1.50 2013/05/05 14:24:05 jdc Exp $");
+__RCSID("$NetBSD: setterm.c,v 1.51 2013/09/25 03:28:20 dsainty Exp $");
#endif
#endif /* not lint */
@@ -172,6 +172,7 @@ _cursesi_setterm(char *type, SCREEN *scr
* It might turn off ACS, so check for that.
*/
if (t_exit_attribute_mode(screen->term) != NULL &&
+ t_exit_alt_charset_mode(screen->term) != NULL &&
does_ctrl_o(t_exit_attribute_mode(screen->term),
t_exit_alt_charset_mode(screen->term)))
screen->mask_me = 0;
