Module Name:    src
Committed By:   dholland
Date:           Mon Oct  7 05:19:23 UTC 2013

Modified Files:
        src/sys/ufs/lfs: lfs_syscalls.c

Log Message:
Remove stray KERNEL_UNLOCK_ONE() in error path of lfs_markv().
>From Wolfgang Stukenbrock in PR 44370.

This error path is only reachable if lfs_markv is handed an out of
range inode number, so it's unlikely that it gets tickled very often.

It isn't clear to me that we need the kernel lock in here at all, as
the path to lfs_markv that's actually used at this point (via fcntl)
doesn't take it. But, one thing at a time.


To generate a diff of this commit:
cvs rdiff -u -r1.148 -r1.149 src/sys/ufs/lfs/lfs_syscalls.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/ufs/lfs/lfs_syscalls.c
diff -u src/sys/ufs/lfs/lfs_syscalls.c:1.148 src/sys/ufs/lfs/lfs_syscalls.c:1.149
--- src/sys/ufs/lfs/lfs_syscalls.c:1.148	Sun Jul 28 01:05:52 2013
+++ src/sys/ufs/lfs/lfs_syscalls.c	Mon Oct  7 05:19:23 2013
@@ -1,4 +1,4 @@
-/*	$NetBSD: lfs_syscalls.c,v 1.148 2013/07/28 01:05:52 dholland Exp $	*/
+/*	$NetBSD: lfs_syscalls.c,v 1.149 2013/10/07 05:19:23 dholland Exp $	*/
 
 /*-
  * Copyright (c) 1999, 2000, 2001, 2002, 2003, 2007, 2007, 2008
@@ -61,7 +61,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: lfs_syscalls.c,v 1.148 2013/07/28 01:05:52 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: lfs_syscalls.c,v 1.149 2013/10/07 05:19:23 dholland Exp $");
 
 #ifndef LFS
 # define LFS		/* for prototypes in syscallargs.h */
@@ -524,7 +524,6 @@ err2:
 	 */
 
 err3:
-	KERNEL_UNLOCK_ONE(NULL);
 	/*
 	 * XXX should do segwrite here anyway?
 	 */

Reply via email to