Module Name:    src
Committed By:   martin
Date:           Mon Dec 30 08:43:28 UTC 2013

Modified Files:
        src/sys/arch/sparc/stand/common: promdev.c

Log Message:
Avoid buffer overruns (no practical difference for any sane firmware
properties, but better be safe).


To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 src/sys/arch/sparc/stand/common/promdev.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/sparc/stand/common/promdev.c
diff -u src/sys/arch/sparc/stand/common/promdev.c:1.26 src/sys/arch/sparc/stand/common/promdev.c:1.27
--- src/sys/arch/sparc/stand/common/promdev.c:1.26	Thu Sep  2 03:14:42 2010
+++ src/sys/arch/sparc/stand/common/promdev.c	Mon Dec 30 08:43:28 2013
@@ -1,4 +1,4 @@
-/*	$NetBSD: promdev.c,v 1.26 2010/09/02 03:14:42 uwe Exp $ */
+/*	$NetBSD: promdev.c,v 1.27 2013/12/30 08:43:28 martin Exp $ */
 
 /*
  * Copyright (c) 1993 Paul Kranenburg
@@ -583,6 +583,8 @@ mygetpropstring(int node, char *name)
 static	char buf[64];
 
 	len = prom_proplen(node, name);
+	if (len > sizeof(buf))
+		len = sizeof(buf)-1;
 	if (len > 0)
 		_prom_getprop(node, name, buf, len);
 	else

Reply via email to