Module Name:    src
Committed By:   dholland
Date:           Sun Mar 23 00:17:40 UTC 2014

Modified Files:
        src/games: Makefile.inc

Log Message:
Add note cautioning against bothering with WARNS=6 until gcc improves
(or -Wconversion is removed from WARNS=6) as it produces loads of false
positives. The most entertaining of these that I've seen this afternoon:

games/hack/hack.apply.c:143:22: error: conversion to 'unsigned char:1' from 
'int' may alter its value [-Werror=conversion]
   flags.move = multi = 0;
                      ^


To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/games/Makefile.inc

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/games/Makefile.inc
diff -u src/games/Makefile.inc:1.15 src/games/Makefile.inc:1.16
--- src/games/Makefile.inc:1.15	Tue Jun 19 05:46:08 2012
+++ src/games/Makefile.inc	Sun Mar 23 00:17:40 2014
@@ -1,4 +1,4 @@
-#	$NetBSD: Makefile.inc,v 1.15 2012/06/19 05:46:08 dholland Exp $
+#	$NetBSD: Makefile.inc,v 1.16 2014/03/23 00:17:40 dholland Exp $
 #	@(#)Makefile.inc	8.1 (Berkeley) 5/31/93
 
 MKHIDEGAME?=	no
@@ -20,4 +20,7 @@ BINGRP=		games
 BINMODE=	2555
 .endif
 .endif
+# Note: do not bother with WARNS=6 until -Wconversion is either
+# removed from WARNS=6 or rendered useful by improving gcc; as it is
+# (with gcc48) it produces buckets of drivel.
 WARNS?=		5

Reply via email to