Module Name:    src
Committed By:   dholland
Date:           Sun Mar 23 05:09:56 UTC 2014

Modified Files:
        src/sbin/amrctl: amrctl.c

Log Message:
don't use sprintf


To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sbin/amrctl/amrctl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sbin/amrctl/amrctl.c
diff -u src/sbin/amrctl/amrctl.c:1.9 src/sbin/amrctl/amrctl.c:1.10
--- src/sbin/amrctl/amrctl.c:1.9	Fri May 18 14:01:34 2012
+++ src/sbin/amrctl/amrctl.c	Sun Mar 23 05:09:56 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: amrctl.c,v 1.9 2012/05/18 14:01:34 jakllsch Exp $	*/
+/*	$NetBSD: amrctl.c,v 1.10 2014/03/23 05:09:56 dholland Exp $	*/
 
 /*-
  * Copyright (c) 2002, Pierre David <[email protected]>
@@ -29,7 +29,7 @@
 
 #include <sys/cdefs.h>
 #ifndef lint
-__RCSID("$NetBSD: amrctl.c,v 1.9 2012/05/18 14:01:34 jakllsch Exp $");
+__RCSID("$NetBSD: amrctl.c,v 1.10 2014/03/23 05:09:56 dholland Exp $");
 #endif
 
 #include <stdio.h>
@@ -311,18 +311,21 @@ describe_card(int fd, int verbosity, int
 					 */
 					product = "HP NetRaid 3si";
 				}
-				sprintf(firmware, "%c.%02d.%02d",
+				snprintf(firmware, sizeof(firmware),
+					"%c.%02d.%02d",
 					ae->ae_adapter.aa_firmware[2],
 					ae->ae_adapter.aa_firmware[1],
 					ae->ae_adapter.aa_firmware[0]);
-				sprintf(bios, "%c.%02d.%02d",
+				snprintf(bios, sizeof(bios),
+					"%c.%02d.%02d",
 					ae->ae_adapter.aa_bios[2],
 					ae->ae_adapter.aa_bios[1],
 					ae->ae_adapter.aa_bios[0]);
 			} else {
-				sprintf(firmware, "%.4s",
+				snprintf(firmware, sizeof(firmware), "%.4s",
 					ae->ae_adapter.aa_firmware);
-				sprintf(bios, "%.4s", ae->ae_adapter.aa_bios);
+				snprintf(bios, sizeof(bios), "%.4s",
+					ae->ae_adapter.aa_bios);
 			}
 
 			printf("Ioctl = %d (%s)\n", FIRMWARE_8LD, "8LD");

Reply via email to