Module Name:    src
Committed By:   jmcneill
Date:           Sat Sep  6 23:04:11 UTC 2014

Modified Files:
        src/sys/arch/arm/allwinner: awin_ac.c

Log Message:
change order of dma setup and use the correct dma channel in 
awinac_trigger_input


To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/arch/arm/allwinner/awin_ac.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/arm/allwinner/awin_ac.c
diff -u src/sys/arch/arm/allwinner/awin_ac.c:1.11 src/sys/arch/arm/allwinner/awin_ac.c:1.12
--- src/sys/arch/arm/allwinner/awin_ac.c:1.11	Sat Sep  6 22:48:19 2014
+++ src/sys/arch/arm/allwinner/awin_ac.c	Sat Sep  6 23:04:10 2014
@@ -1,4 +1,4 @@
-/* $NetBSD: awin_ac.c,v 1.11 2014/09/06 22:48:19 jmcneill Exp $ */
+/* $NetBSD: awin_ac.c,v 1.12 2014/09/06 23:04:10 jmcneill Exp $ */
 
 /*-
  * Copyright (c) 2014 Jared D. McNeill <[email protected]>
@@ -30,7 +30,7 @@
 #include "opt_ddb.h"
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: awin_ac.c,v 1.11 2014/09/06 22:48:19 jmcneill Exp $");
+__KERNEL_RCSID(0, "$NetBSD: awin_ac.c,v 1.12 2014/09/06 23:04:10 jmcneill Exp $");
 
 #include <sys/param.h>
 #include <sys/bus.h>
@@ -951,10 +951,6 @@ awinac_trigger_output(void *priv, void *
 	sc->sc_pend = sc->sc_pstart + psize;
 	sc->sc_pblksize = blksize;
 
-	val = AC_READ(sc, AC_DAC_FIFOC);
-	val |= DAC_FIFOC_DRQ_EN;
-	AC_WRITE(sc, AC_DAC_FIFOC, val);
-
 	dmacfg = 0;
 	dmacfg |= __SHIFTIN(AWIN_DMA_CTL_DATA_WIDTH_16,
 			    AWIN_DMA_CTL_DST_DATA_WIDTH);
@@ -972,6 +968,10 @@ awinac_trigger_output(void *priv, void *
 			    AWIN_DMA_CTL_SRC_DRQ_TYPE);
 	awin_dma_set_config(sc->sc_pdma, dmacfg);
 
+	val = AC_READ(sc, AC_DAC_FIFOC);
+	val |= DAC_FIFOC_DRQ_EN;
+	AC_WRITE(sc, AC_DAC_FIFOC, val);
+
 	error = awinac_play(sc);
 	if (error)
 		awinac_halt_output(sc);
@@ -1019,10 +1019,6 @@ awinac_trigger_input(void *priv, void *s
 	sc->sc_rend = sc->sc_rstart + rsize;
 	sc->sc_rblksize = blksize;
 
-	val = AC_READ(sc, AC_ADC_FIFOC);
-	val |= ADC_FIFOC_DRQ_EN;
-	AC_WRITE(sc, AC_ADC_FIFOC, val);
-
 	dmacfg = 0;
 	dmacfg |= __SHIFTIN(AWIN_DMA_CTL_DATA_WIDTH_16,
 			    AWIN_DMA_CTL_DST_DATA_WIDTH);
@@ -1038,7 +1034,11 @@ awinac_trigger_input(void *priv, void *s
 			    AWIN_DMA_CTL_DST_DRQ_TYPE);
 	dmacfg |= __SHIFTIN(AWIN_NDMA_CTL_DRQ_CODEC,
 			    AWIN_DMA_CTL_SRC_DRQ_TYPE);
-	awin_dma_set_config(sc->sc_pdma, dmacfg);
+	awin_dma_set_config(sc->sc_rdma, dmacfg);
+
+	val = AC_READ(sc, AC_ADC_FIFOC);
+	val |= ADC_FIFOC_DRQ_EN;
+	AC_WRITE(sc, AC_ADC_FIFOC, val);
 
 	error = awinac_rec(sc);
 	if (error)

Reply via email to