Module Name: src
Committed By: maxv
Date: Mon Oct 20 06:56:38 UTC 2014
Modified Files:
src/sys/compat/common: vfs_syscalls_30.c
Log Message:
Memory leak, triggerable from root only.
Found by my code scanner.
ok christos@
To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 src/sys/compat/common/vfs_syscalls_30.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/compat/common/vfs_syscalls_30.c
diff -u src/sys/compat/common/vfs_syscalls_30.c:1.34 src/sys/compat/common/vfs_syscalls_30.c:1.35
--- src/sys/compat/common/vfs_syscalls_30.c:1.34 Fri Sep 5 09:21:54 2014
+++ src/sys/compat/common/vfs_syscalls_30.c Mon Oct 20 06:56:38 2014
@@ -1,4 +1,4 @@
-/* $NetBSD: vfs_syscalls_30.c,v 1.34 2014/09/05 09:21:54 matt Exp $ */
+/* $NetBSD: vfs_syscalls_30.c,v 1.35 2014/10/20 06:56:38 maxv Exp $ */
/*-
* Copyright (c) 2005, 2008 The NetBSD Foundation, Inc.
@@ -29,7 +29,7 @@
* POSSIBILITY OF SUCH DAMAGE.
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: vfs_syscalls_30.c,v 1.34 2014/09/05 09:21:54 matt Exp $");
+__KERNEL_RCSID(0, "$NetBSD: vfs_syscalls_30.c,v 1.35 2014/10/20 06:56:38 maxv Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@@ -356,9 +356,13 @@ compat_30_sys_getfh(struct lwp *l, const
}
NDINIT(&nd, LOOKUP, FOLLOW | LOCKLEAF | TRYEMULROOT, pb);
error = namei(&nd);
- if (error)
+ if (error) {
+ pathbuf_destroy(pb);
return (error);
+ }
vp = nd.ni_vp;
+ pathbuf_destroy(pb);
+
sz = sizeof(struct compat_30_fhandle);
error = vfs_composefh(vp, (void *)&fh, &sz);
vput(vp);
