Module Name: src
Committed By: maxv
Date: Sat Feb 7 10:40:57 UTC 2015
Modified Files:
src/sys/fs/nilfs: nilfs_vfsops.c
Log Message:
Revert previous, it was a false positive.
In nilfs_mount_device() there's one branch where the node is not released:
when the device is already mounted. Not releasing it was thus intentional,
but this is something code scanners can't understand.
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/fs/nilfs/nilfs_vfsops.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/fs/nilfs/nilfs_vfsops.c
diff -u src/sys/fs/nilfs/nilfs_vfsops.c:1.19 src/sys/fs/nilfs/nilfs_vfsops.c:1.20
--- src/sys/fs/nilfs/nilfs_vfsops.c:1.19 Sat Feb 7 04:25:16 2015
+++ src/sys/fs/nilfs/nilfs_vfsops.c Sat Feb 7 10:40:57 2015
@@ -1,4 +1,4 @@
-/* $NetBSD: nilfs_vfsops.c,v 1.19 2015/02/07 04:25:16 christos Exp $ */
+/* $NetBSD: nilfs_vfsops.c,v 1.20 2015/02/07 10:40:57 maxv Exp $ */
/*
* Copyright (c) 2008, 2009 Reinoud Zandijk
@@ -28,7 +28,7 @@
#include <sys/cdefs.h>
#ifndef lint
-__KERNEL_RCSID(0, "$NetBSD: nilfs_vfsops.c,v 1.19 2015/02/07 04:25:16 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nilfs_vfsops.c,v 1.20 2015/02/07 10:40:57 maxv Exp $");
#endif /* not lint */
@@ -879,10 +879,8 @@ nilfs_mount(struct mount *mp, const char
#endif
error = nilfs_mount_device(devvp, mp, args, &nilfsdev);
- if (error) {
- vrele(devvp);
+ if (error)
return error;
- }
/*
* Create a nilfs_mount on the specified checkpoint. Note that only
