Module Name:    src
Committed By:   rtr
Date:           Sat May  2 21:15:33 UTC 2015

Modified Files:
        src/sys/kern: uipc_socket.c

Log Message:
remove unnecessary check that nam != NULL before deref in soconnect()
(added in previous commit).

sockargs copyin() makes sure we don't get NULL here


To generate a diff of this commit:
cvs rdiff -u -r1.241 -r1.242 src/sys/kern/uipc_socket.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/kern/uipc_socket.c
diff -u src/sys/kern/uipc_socket.c:1.241 src/sys/kern/uipc_socket.c:1.242
--- src/sys/kern/uipc_socket.c:1.241	Sat May  2 20:10:26 2015
+++ src/sys/kern/uipc_socket.c	Sat May  2 21:15:33 2015
@@ -1,4 +1,4 @@
-/*	$NetBSD: uipc_socket.c,v 1.241 2015/05/02 20:10:26 rtr Exp $	*/
+/*	$NetBSD: uipc_socket.c,v 1.242 2015/05/02 21:15:33 rtr Exp $	*/
 
 /*-
  * Copyright (c) 2002, 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -71,7 +71,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.241 2015/05/02 20:10:26 rtr Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.242 2015/05/02 21:15:33 rtr Exp $");
 
 #include "opt_compat_netbsd.h"
 #include "opt_sock_counters.h"
@@ -830,8 +830,7 @@ soconnect(struct socket *so, struct sock
 	    (error = sodisconnect(so)))) {
 		error = EISCONN;
 	} else {
-		if (NULL != nam &&
-		    nam->sa_family != so->so_proto->pr_domain->dom_family) {
+		if (nam->sa_family != so->so_proto->pr_domain->dom_family) {
 			return EAFNOSUPPORT;
 		}
 		error = (*so->so_proto->pr_usrreqs->pr_connect)(so, nam, l);

Reply via email to