Module Name: src
Committed By: maxv
Date: Tue Oct 11 12:53:56 UTC 2016
Modified Files:
src/sys/dev/pci/cxgb: cxgb_l2t.c
Log Message:
There are two memory leaks here, found by mootja; just add some XXXs.
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/pci/cxgb/cxgb_l2t.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/pci/cxgb/cxgb_l2t.c
diff -u src/sys/dev/pci/cxgb/cxgb_l2t.c:1.3 src/sys/dev/pci/cxgb/cxgb_l2t.c:1.4
--- src/sys/dev/pci/cxgb/cxgb_l2t.c:1.3 Tue Mar 25 16:19:14 2014
+++ src/sys/dev/pci/cxgb/cxgb_l2t.c Tue Oct 11 12:53:56 2016
@@ -28,7 +28,7 @@ POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: cxgb_l2t.c,v 1.3 2014/03/25 16:19:14 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: cxgb_l2t.c,v 1.4 2016/10/11 12:53:56 maxv Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@@ -127,7 +127,7 @@ setup_l2e_send_pending(struct toedev *de
memcpy(req->dst_mac, e->dmac, sizeof(req->dst_mac));
m_set_priority(m, CPL_PRIORITY_CONTROL);
while (e->arpq_head) {
- m = e->arpq_head;
+ m = e->arpq_head; /* XXX XXX XXX: Memory leak? */
e->arpq_head = m->m_next;
m->m_next = NULL;
}
@@ -182,6 +182,7 @@ again:
arpq_enqueue(e, m);
mtx_unlock(&e->lock);
+ /* XXX XXX XXX: Memory leak? */
if ((m0 = m_gethdr(M_NOWAIT, MT_DATA)) == NULL)
return (ENOMEM);
/*
