Module Name: src
Committed By: maxv
Date: Mon Oct 31 15:08:45 UTC 2016
Modified Files:
src/sys/kern: uipc_sem.c
Log Message:
Memory leak, found by Mootja. By the way, we probably shouldn't be
returning -1 here.
To generate a diff of this commit:
cvs rdiff -u -r1.46 -r1.47 src/sys/kern/uipc_sem.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/kern/uipc_sem.c
diff -u src/sys/kern/uipc_sem.c:1.46 src/sys/kern/uipc_sem.c:1.47
--- src/sys/kern/uipc_sem.c:1.46 Fri Jun 10 23:24:33 2016
+++ src/sys/kern/uipc_sem.c Mon Oct 31 15:08:45 2016
@@ -1,4 +1,4 @@
-/* $NetBSD: uipc_sem.c,v 1.46 2016/06/10 23:24:33 christos Exp $ */
+/* $NetBSD: uipc_sem.c,v 1.47 2016/10/31 15:08:45 maxv Exp $ */
/*-
* Copyright (c) 2011 The NetBSD Foundation, Inc.
@@ -60,7 +60,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uipc_sem.c,v 1.46 2016/06/10 23:24:33 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uipc_sem.c,v 1.47 2016/10/31 15:08:45 maxv Exp $");
#include <sys/param.h>
#include <sys/kernel.h>
@@ -335,9 +335,11 @@ ksem_create(lwp_t *l, const char *name,
}
if (atomic_inc_uint_nv(&l->l_proc->p_nsems) > SEM_NSEMS_MAX) {
- atomic_dec_uint(&l->l_proc->p_nsems);
+ atomic_dec_uint(&l->l_proc->p_nsems);
+ if (kname != NULL)
+ kmem_free(kname, len);
return -1;
- }
+ }
ks = kmem_zalloc(sizeof(ksem_t), KM_SLEEP);
mutex_init(&ks->ks_lock, MUTEX_DEFAULT, IPL_NONE);
