Module Name:    src
Committed By:   knakahara
Date:           Fri Nov 18 08:13:02 UTC 2016

Modified Files:
        src/sys/net: if_pppoe.c

Log Message:
if_register() must be called after ifp->if_dl initialized.

There may be similar problems. I will fix step by step...


To generate a diff of this commit:
cvs rdiff -u -r1.118 -r1.119 src/sys/net/if_pppoe.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/net/if_pppoe.c
diff -u src/sys/net/if_pppoe.c:1.118 src/sys/net/if_pppoe.c:1.119
--- src/sys/net/if_pppoe.c:1.118	Mon Oct  3 11:06:06 2016
+++ src/sys/net/if_pppoe.c	Fri Nov 18 08:13:02 2016
@@ -1,4 +1,4 @@
-/* $NetBSD: if_pppoe.c,v 1.118 2016/10/03 11:06:06 ozaki-r Exp $ */
+/* $NetBSD: if_pppoe.c,v 1.119 2016/11/18 08:13:02 knakahara Exp $ */
 
 /*-
  * Copyright (c) 2002, 2008 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_pppoe.c,v 1.118 2016/10/03 11:06:06 ozaki-r Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_pppoe.c,v 1.119 2016/11/18 08:13:02 knakahara Exp $");
 
 #ifdef _KERNEL_OPT
 #include "pppoe.h"
@@ -284,8 +284,10 @@ pppoe_clone_create(struct if_clone *ifc,
 	sc->sc_sppp.pp_tlf = pppoe_tlf;
 	sc->sc_sppp.pp_framebytes = PPPOE_HEADERLEN;	/* framing added to ppp packets */
 
-	if_attach(&sc->sc_sppp.pp_if);
+	if_initialize(&sc->sc_sppp.pp_if);
+	sc->sc_sppp.pp_if.if_percpuq = if_percpuq_create(&sc->sc_sppp.pp_if);
 	sppp_attach(&sc->sc_sppp.pp_if);
+	if_register(&sc->sc_sppp.pp_if);
 
 	bpf_attach(&sc->sc_sppp.pp_if, DLT_PPP_ETHER, 0);
 	if (LIST_EMPTY(&pppoe_softc_list)) {

Reply via email to