CVS commit: src/tests/lib/libc/c063

[Christos Zoulas]

Module Name:    src
Committed By:   christos
Date:           Tue Jan 10 15:15:09 UTC 2017

Modified Files:
        src/tests/lib/libc/c063: t_fexecve.c t_mkfifoat.c t_mknodat.c

Log Message:
PR/51805: Ngie Cooper: Fix file descriptor leaks


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libc/c063/t_fexecve.c \
    src/tests/lib/libc/c063/t_mkfifoat.c
cvs rdiff -u -r1.3 -r1.4 src/tests/lib/libc/c063/t_mknodat.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


Modified files:

Index: src/tests/lib/libc/c063/t_fexecve.c
diff -u src/tests/lib/libc/c063/t_fexecve.c:1.2 src/tests/lib/libc/c063/t_fexecve.c:1.3
--- src/tests/lib/libc/c063/t_fexecve.c:1.2	Sun Mar 17 00:35:59 2013
+++ src/tests/lib/libc/c063/t_fexecve.c	Tue Jan 10 10:15:09 2017
@@ -1,4 +1,4 @@
-/*	$NetBSD: t_fexecve.c,v 1.2 2013/03/17 04:35:59 jmmv Exp $ */
+/*	$NetBSD: t_fexecve.c,v 1.3 2017/01/10 15:15:09 christos Exp $ */
 
 /*-
  * Copyright (c) 2012 The NetBSD Foundation, Inc.
@@ -29,7 +29,7 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 #include <sys/cdefs.h>
-__RCSID("$NetBSD: t_fexecve.c,v 1.2 2013/03/17 04:35:59 jmmv Exp $");
+__RCSID("$NetBSD: t_fexecve.c,v 1.3 2017/01/10 15:15:09 christos Exp $");
 
 #include <sys/wait.h>
 
@@ -70,6 +70,7 @@ ATF_TC_BODY(fexecve, tc)
 				error = 76;
 			else
 				error = EXIT_FAILURE;
+			(void)close(fd);
 			err(error, "fexecve");
 		}
 	}
Index: src/tests/lib/libc/c063/t_mkfifoat.c
diff -u src/tests/lib/libc/c063/t_mkfifoat.c:1.2 src/tests/lib/libc/c063/t_mkfifoat.c:1.3
--- src/tests/lib/libc/c063/t_mkfifoat.c:1.2	Sun Mar 17 00:46:06 2013
+++ src/tests/lib/libc/c063/t_mkfifoat.c	Tue Jan 10 10:15:09 2017
@@ -1,4 +1,4 @@
-/*	$NetBSD: t_mkfifoat.c,v 1.2 2013/03/17 04:46:06 jmmv Exp $ */
+/*	$NetBSD: t_mkfifoat.c,v 1.3 2017/01/10 15:15:09 christos Exp $ */
 
 /*-
  * Copyright (c) 2012 The NetBSD Foundation, Inc.
@@ -29,7 +29,7 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 #include <sys/cdefs.h>
-__RCSID("$NetBSD: t_mkfifoat.c,v 1.2 2013/03/17 04:46:06 jmmv Exp $");
+__RCSID("$NetBSD: t_mkfifoat.c,v 1.3 2017/01/10 15:15:09 christos Exp $");
 
 #include <atf-c.h>
 #include <errno.h>
@@ -63,6 +63,7 @@ ATF_TC_BODY(mkfifoat_fd, tc)
 	ATF_REQUIRE((fd = mkfifoat(dfd, BASEFIFO, mode)) != -1);
 	ATF_REQUIRE(close(fd) == 0);
 	ATF_REQUIRE(access(FIFO, F_OK) == 0);
+	(void)close(dfd);
 }
 
 ATF_TC(mkfifoat_fdcwd);

Index: src/tests/lib/libc/c063/t_mknodat.c
diff -u src/tests/lib/libc/c063/t_mknodat.c:1.3 src/tests/lib/libc/c063/t_mknodat.c:1.4
--- src/tests/lib/libc/c063/t_mknodat.c:1.3	Sun Mar 17 00:46:06 2013
+++ src/tests/lib/libc/c063/t_mknodat.c	Tue Jan 10 10:15:09 2017
@@ -1,4 +1,4 @@
-/*	$NetBSD: t_mknodat.c,v 1.3 2013/03/17 04:46:06 jmmv Exp $ */
+/*	$NetBSD: t_mknodat.c,v 1.4 2017/01/10 15:15:09 christos Exp $ */
 
 /*-
  * Copyright (c) 2012 The NetBSD Foundation, Inc.
@@ -29,7 +29,7 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 #include <sys/cdefs.h>
-__RCSID("$NetBSD: t_mknodat.c,v 1.3 2013/03/17 04:46:06 jmmv Exp $");
+__RCSID("$NetBSD: t_mknodat.c,v 1.4 2017/01/10 15:15:09 christos Exp $");
 
 #include <atf-c.h>
 #include <errno.h>
@@ -80,6 +80,7 @@ ATF_TC_BODY(mknodat_fd, tc)
 	ATF_REQUIRE((fd = mknodat(dfd, BASEFILE, mode, dev)) != -1);
 	ATF_REQUIRE(close(fd) == 0);
 	ATF_REQUIRE(access(FILE, F_OK) == 0);
+	(void)close(dfd);
 }
 
 ATF_TC(mknodat_fdcwd);