Module Name:    src
Committed By:   joerg
Date:           Wed Jan 11 12:14:32 UTC 2017

Modified Files:
        src/sys/arch/sparc/sparc: db_disasm.c

Log Message:
Don't cast the result of abs() to int, but the argument.


To generate a diff of this commit:
cvs rdiff -u -r1.21 -r1.22 src/sys/arch/sparc/sparc/db_disasm.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/sparc/sparc/db_disasm.c
diff -u src/sys/arch/sparc/sparc/db_disasm.c:1.21 src/sys/arch/sparc/sparc/db_disasm.c:1.22
--- src/sys/arch/sparc/sparc/db_disasm.c:1.21	Sun Oct  4 08:16:13 2015
+++ src/sys/arch/sparc/sparc/db_disasm.c	Wed Jan 11 12:14:32 2017
@@ -1,4 +1,4 @@
-/*	$NetBSD: db_disasm.c,v 1.21 2015/10/04 08:16:13 joerg Exp $ */
+/*	$NetBSD: db_disasm.c,v 1.22 2017/01/11 12:14:32 joerg Exp $ */
 
 /*
  * Copyright (c) 1994 David S. Miller, da...@nadzieja.rutgers.edu
@@ -32,7 +32,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: db_disasm.c,v 1.21 2015/10/04 08:16:13 joerg Exp $");
+__KERNEL_RCSID(0, "$NetBSD: db_disasm.c,v 1.22 2017/01/11 12:14:32 joerg Exp $");
 
 #include <sys/param.h>
 #include <machine/db_machdep.h>
@@ -995,12 +995,12 @@ db_disasm(vaddr_t loc, bool altfmt)
 		case 'i':
 			/* simm13 -- signed */
 			val = SIGNEX(insn, 13);
-			db_printf("%s0x%x", SIGN(val), (int)abs(val));
+			db_printf("%s0x%x", SIGN(val), abs((int)val));
 			break;
 		case 'j':
 			/* simm11 -- signed */
 			val = SIGNEX(insn, 11);
-			db_printf("%s0x%x", SIGN(val), (int)abs(val));
+			db_printf("%s0x%x", SIGN(val), abs((int)val));
 			break;
 		case 'l':
 			val = (((insn>>20)&0x3)<<13)|(insn & 0x1fff);
@@ -1043,7 +1043,7 @@ db_disasm(vaddr_t loc, bool altfmt)
 			db_printf("[%%%s %c 0x%x]",
 				regs[((insn >> 14) & 0x1f)],
 				(int)((val<0)?'-':'+'),
-				(int)abs(val));
+				abs((int)val));
 			if (*f_ptr == '8')
 				db_printf(" %%asi");
 			break;

Reply via email to