Module Name:    src
Committed By:   knakahara
Date:           Tue Jun  6 01:48:34 UTC 2017

Modified Files:
        src/sys/opencrypto: cryptodev.h

Log Message:
add locking notes.


To generate a diff of this commit:
cvs rdiff -u -r1.35 -r1.36 src/sys/opencrypto/cryptodev.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/opencrypto/cryptodev.h
diff -u src/sys/opencrypto/cryptodev.h:1.35 src/sys/opencrypto/cryptodev.h:1.36
--- src/sys/opencrypto/cryptodev.h:1.35	Tue Jun  6 01:45:57 2017
+++ src/sys/opencrypto/cryptodev.h	Tue Jun  6 01:48:33 2017
@@ -1,4 +1,4 @@
-/*	$NetBSD: cryptodev.h,v 1.35 2017/06/06 01:45:57 knakahara Exp $ */
+/*	$NetBSD: cryptodev.h,v 1.36 2017/06/06 01:48:33 knakahara Exp $ */
 /*	$FreeBSD: src/sys/opencrypto/cryptodev.h,v 1.2.2.6 2003/07/02 17:04:50 sam Exp $	*/
 /*	$OpenBSD: cryptodev.h,v 1.33 2002/07/17 23:52:39 art Exp $	*/
 
@@ -646,4 +646,18 @@ extern int	cuio_getptr(struct uio *, int
 #endif
 
 #endif /* _KERNEL */
+/*
+ * Locking notes:
+ * + crypto_drivers itself is protected by crypto_drv_mtx (an adaptive lock)
+ * + crypto_drivers[i] and its all members are protected by
+ *   crypto_drivers[i].cc_lock (a spin lock)
+ *       spin lock as crypto_unblock() can be called in interrupt context
+ * + crp_q and crp_kq are procted by crypto_q_mtx (an adaptive lock)
+ * + crp_ret_q, crp_ret_kq and crypto_exit_flag are protected by
+ *   crypto_ret_q_mtx (a spin lock)
+ *       spin lock as crypto_done() can be called in interrupt context
+ *
+ * Locking order:
+ *     - crypto_q_mtx => crypto_drv_mtx => crypto_drivers[i].cc_lock
+ */
 #endif /* _CRYPTO_CRYPTO_H_ */

Reply via email to