Module Name:    src
Committed By:   knakahara
Date:           Thu Jun 29 08:51:27 UTC 2017

Modified Files:
        src/sys/rump/dev/lib/libopencrypto: opencrypto_component.c

Log Message:
reduce rump waring message. pointed out by [email protected], thanks.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 \
    src/sys/rump/dev/lib/libopencrypto/opencrypto_component.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/rump/dev/lib/libopencrypto/opencrypto_component.c
diff -u src/sys/rump/dev/lib/libopencrypto/opencrypto_component.c:1.4 src/sys/rump/dev/lib/libopencrypto/opencrypto_component.c:1.5
--- src/sys/rump/dev/lib/libopencrypto/opencrypto_component.c:1.4	Tue Jan 26 23:12:15 2016
+++ src/sys/rump/dev/lib/libopencrypto/opencrypto_component.c	Thu Jun 29 08:51:27 2017
@@ -1,4 +1,4 @@
-/*	$NetBSD: opencrypto_component.c,v 1.4 2016/01/26 23:12:15 pooka Exp $ */
+/*	$NetBSD: opencrypto_component.c,v 1.5 2017/06/29 08:51:27 knakahara Exp $ */
 
 /*
  * Copyright (c) 2009 Antti Kantee.  All Rights Reserved.
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: opencrypto_component.c,v 1.4 2016/01/26 23:12:15 pooka Exp $");
+__KERNEL_RCSID(0, "$NetBSD: opencrypto_component.c,v 1.5 2017/06/29 08:51:27 knakahara Exp $");
 
 #include <sys/param.h>
 #include <sys/conf.h>
@@ -64,5 +64,20 @@ RUMP_COMPONENT(RUMP_COMPONENT_DEV)
 	 */
 	crypto_init();
 	rump_pdev_add(cryptoattach, 1);
+#if 0
+	/*
+	 * rump defines "_MODULE" in spite of using built-in module
+	 * initialization(module_init_class()). So, swcryptoattach_internal()
+	 * is called by two functions, one is swcryptoattach() and the other is
+	 * swcrypto_modcmd().
+	 * That causes "builtin module `swcrypto' failed to init" WARNING message.
+	 * To suppress this warning, we let rump use swcrypto_modcmd() call-path
+	 * only.
+	 *
+	 * TODO:
+	 * There is still "crypto: unable to register devsw" message. it should
+	 * be suppressed.
+	 */
 	rump_pdev_add(swcryptoattach, 0);
+#endif
 }

Reply via email to