Module Name: src
Committed By: jdolecek
Date: Mon Sep 11 22:30:05 UTC 2017
Modified Files:
src/sys/dev/ata [jdolecek-ncq]: TODO.ncq
Log Message:
atastart() rechecked - it's okay to call it even in error path in those
several cases we do, it's just optimization to skip the call; I'm not even
very convinced it's useful to have this conditional, but keeping for now
until proven harmful
To generate a diff of this commit:
cvs rdiff -u -r1.1.2.38 -r1.1.2.39 src/sys/dev/ata/TODO.ncq
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/ata/TODO.ncq
diff -u src/sys/dev/ata/TODO.ncq:1.1.2.38 src/sys/dev/ata/TODO.ncq:1.1.2.39
--- src/sys/dev/ata/TODO.ncq:1.1.2.38 Sun Sep 10 19:31:15 2017
+++ src/sys/dev/ata/TODO.ncq Mon Sep 11 22:30:05 2017
@@ -2,11 +2,6 @@ Bugs
----
test wd* at umass?, confirm the ata_channel kludge works
-revise calls to atastart() - now called alsoafter ATASTART_ABORT(), call
-only from intr routine
-- wdc.c never calls atastart() (start always false)
-- ata_wdc.c calls atastart() regardless if error
-
reconsider freeze/thaw in error recovery - can it screw up with thread?
Other random notes (do outside the NCQ branch):
