Module Name:    src
Committed By:   christos
Date:           Sat Jun 30 16:05:44 UTC 2018

Modified Files:
        src/lib/libpuffs: puffs.c

Log Message:
use a switch.


To generate a diff of this commit:
cvs rdiff -u -r1.123 -r1.124 src/lib/libpuffs/puffs.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/lib/libpuffs/puffs.c
diff -u src/lib/libpuffs/puffs.c:1.123 src/lib/libpuffs/puffs.c:1.124
--- src/lib/libpuffs/puffs.c:1.123	Thu Feb  8 04:05:17 2018
+++ src/lib/libpuffs/puffs.c	Sat Jun 30 12:05:44 2018
@@ -1,4 +1,4 @@
-/*	$NetBSD: puffs.c,v 1.123 2018/02/08 09:05:17 dholland Exp $	*/
+/*	$NetBSD: puffs.c,v 1.124 2018/06/30 16:05:44 christos Exp $	*/
 
 /*
  * Copyright (c) 2005, 2006, 2007  Antti Kantee.  All Rights Reserved.
@@ -31,7 +31,7 @@
 
 #include <sys/cdefs.h>
 #if !defined(lint)
-__RCSID("$NetBSD: puffs.c,v 1.123 2018/02/08 09:05:17 dholland Exp $");
+__RCSID("$NetBSD: puffs.c,v 1.124 2018/06/30 16:05:44 christos Exp $");
 #endif /* !lint */
 
 #include <sys/param.h>
@@ -904,21 +904,23 @@ puffs__theloop(struct puffs_cc *pcc)
 			}
 
 			what = 0;
-			if (curev->filter == EVFILT_READ) {
+			switch (curev->filter) {
+			case EVFILT_READ:
 				puffs__framev_input(pu, pfctrl, fio);
 				what |= PUFFS_FBIO_READ;
-			}
-
-			else if (curev->filter == EVFILT_WRITE) {
+				break;
+			case EVFILT_WRITE:
 				puffs__framev_output(pu, pfctrl, fio);
 				what |= PUFFS_FBIO_WRITE;
-			}
-
-			else if (__predict_false(curev->filter==EVFILT_SIGNAL)){
+				break;
+			case EVFILT_SIGNAL:
 				if ((pu->pu_state & PU_DONEXIT) == 0) {
 					PU_SETSFLAG(pu, PU_DONEXIT);
 					puffs_exit(pu, 0);
 				}
+				break;
+			default:
+				warn("unhandled filter %d", curev->filter);
 			}
 			if (what)
 				puffs__framev_notify(fio, what);

Reply via email to